Skip to content

[Feature] dune-modelling step 1

Santiago Ospina De Los Ríos requested to merge feature/dune-modelling-step-1 into master

What does this MR do?

This MR implements the first task associated with issue #40 (closed) which essentially allows using the Richards local operator with the dune-modelling interface. No other guarantees are given at this point.

Although the solver is working, it doesn't have the same functionalities DORiE has already implemented with dune-pdelab, i.e, spatiotemporal adaptivity, and VTK writers. Therefore, this feature should be stated as experimental and it shouldn't affect the normal use of DORiE. Furthermore, the dune-modelling module is marked as suggested, and its absence shouldn't affect either the configuration, installation and use of DORiE.

A new config key is needed:

[misc]
#Possible options: DunePDELab, DuneModelling
simulationType = DuneModelling

Possible conflicts with other branches

Big changes have been made on the structure of the Simulation object. Now it has Traits and a Factory. New MR involving changes in Simulation would have to fit this new structure.

Is there something that needs to be double checked?

No.

Can this MR be accepted?

Obligatory

  • Implemented
  • Added new default parameters for new config keys
  • Pipeline passing without dune-modelling

Optional for this specific MR

  • Added test that checks a success running with dune-modelling
  • Documentation
  • Pipeline passing with dune-modelling

Related issues and MRs

#40 (closed) !20 (closed) !26 (closed)

Merge request reports