Skip to content

WIP: Finite Volume for Solute Transport

Santiago Ospina De Los Ríos requested to merge feature/solute-transport-finite-volume into master

What does this MR do?

Implements solute transport with finite volume method.

This branch gather efforts of branches !65 (merged), !64 (merged) and others already merged branches plus implementation of the solute transport itself.

  • From discussions, we decided that Richards and Transport models will have different ini files. Indeed, for the decoupled version they will be different programs that are managed by the python launcher. Then, the decoupled transport version is now launched with dorie run_transport config.ini, where confing.ini refers to the transport version of the ini file.
  • Since dorie now manages two models I propose to rename the dorie.cc file to richards.cc with equivalent modifications in tests and launcher.
  • So far, the coupling is not implemented.

Is there something that needs to be double checked?

So far no. I will state double checks when this is sent to review.

Can this MR be accepted?

  • Implemented.
  • Added test.
  • Pipeline passing.
  • Documentation done.
  • Added entry to CHANGELOG.md.

Related issues

Edited by Santiago Ospina De Los Ríos

Merge request reports