Skip to content
Snippets Groups Projects

Resolve "Base class for simulations"

Merged Santiago Ospina De Los Ríos requested to merge 94-base-class-for-simulations into master

What does this MR do?

Implements what is proposed in #94 (closed).

  • Add abstract class SimulationBase.
  • Add test test-simulation-base.cc.

Is there something that needs to be double checked?

Can this MR be accepted?

  • Implemented proposal
  • Added unit test
  • Added unit test to the pipeline
  • Pipeline passing
  • Added entry to CHANGELOG.md

Related issues

Closes #94 (closed)

Edited by Lukas Riedel

Merge request reports

Checking pipeline status.

Merged by Lukas RiedelLukas Riedel 6 years ago (Sep 4, 2018 5:26pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Santiago Ospina De Los Ríos marked as a Work In Progress

    marked as a Work In Progress

  • added 1 commit

    • 8917df20 - renamed simulation base file

    Compare with previous version

  • added 1 commit

    • 47e5d483 - renamed functions and added const keywords where needed

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 74e57828 - removed support for pre and post step

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • a79c1d84 - set output policy rule at the end of the step by default

    Compare with previous version

  • mentioned in merge request !89 (merged)

  • Santiago Ospina De Los Ríos marked the checklist item Pipeline passing as completed

    marked the checklist item Pipeline passing as completed

  • Santiago Ospina De Los Ríos unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Santiago Ospina De Los Ríos changed the description

    changed the description

  • mentioned in merge request !93 (merged)

  • mentioned in issue #99 (closed)

  • Santiago Ospina De Los Ríos changed the description

    changed the description

  • Santiago Ospina De Los Ríos marked the checklist item Added unit test to the pipeline as incomplete

    marked the checklist item Added unit test to the pipeline as incomplete

  • Lukas Riedel added 127 commits

    added 127 commits

    • a79c1d84...e05eb529 - 121 commits from branch master
    • f96c5ab1 - Merge branch 'master' into 94-base-class-for-simulations
    • 8634c970 - Merge branch 'fix-errors-from-mr-98' into 94-base-class-for-simulations
    • 3895ff70 - Merge SimulationBase constructors by using default parameters
    • c482c97d - Verify SimulationBase::step routine by adding adaptivity policy to test
    • fff5b51a - Improve unit test of SimulationBase to check for calls to write_data
    • ea28f4b5 - Use new unit test command for SimulationBase test

    Compare with previous version

  • Lukas Riedel marked the checklist item Added unit test to the pipeline as completed

    marked the checklist item Added unit test to the pipeline as completed

  • Lukas Riedel changed the description

    changed the description

  • Lukas Riedel added 1 commit

    added 1 commit

    • b6a50ea1 - Rename test of SimulationBase to test-simulation-base.cc

    Compare with previous version

  • Lukas Riedel added 1 commit

    added 1 commit

    Compare with previous version

  • Lukas Riedel mentioned in commit fedee2f2

    mentioned in commit fedee2f2

  • merged

  • Santiago Ospina De Los Ríos resolved all discussions

    resolved all discussions

  • mentioned in merge request !144 (merged)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading