Skip to content

always link dunealugrid against dunecommon

Simon Praetorius requested to merge simon.praetorius/dune-alugrid:issue/link_dunecommon into master

Summary

Link the dunealugrid explicitly against dunecommon. This is currently only done if CMAKE_HOST_APPLE.

Details

CMake communicates flags and link libraries by targets. So linking against dunecommon sets requirements formulated for dune-common also for dune-alugrid. When the cmake buildsystem gets updated, this might be necessary, since global properties will be removed, and thus would not be set for the dunealugrid target otherwise. One example where the build of dune-alugrid fails is with the core/dune-common!862 (merged) (changing the way the c++-standard is enforced in dune). Linking against dunecommon works already now and does not hurt.

Merge request reports