Add include directories to library target
This properly sets up the dune-alugrid main target to follow modern CMake practices where the target holds all the information to propagate transitively to other targets. The MR also suppresses the warning that a Dune policy is not set, by setting it to NEW. The consequence is that there is no global include_directories(...)
call in dune_project
anymore and one needs to link all targets that need Dune include directories either to the library target Dune::ALUGrid
(or dunealugrid
) or set the include directories manually, e.g., using the utility function dune_default_include_directories(<target> [PUBLIC|PRIVATE|INTERFACE])
. This is especially important for tests. That is why tests should be linked against the library target. (this was done already for all tests in dune-alugrid)
Merge request reports
Activity
added buildsystem label
- Resolved by Santiago Ospina De Los Ríos
This MR requires core/dune-common!1512 (merged) to be merged before. Otherwise the headercheck is not working correctly.
mentioned in merge request core/dune-common!1512 (merged)
mentioned in issue core/dune-common#405
mentioned in commit c407abab