set geometry mixins automatically, if not defined

added 2 commits

• 1abc3baa - `is_yaspgrid` checks itself if the `grid_unstructured` option is set
• d6c4bc2f - removes too strict assertion

Compare with previous version

added 1 commit

• a48b1b8e - update some tests

Compare with previous version

changed target branch from feature/geometry-mixins to master

added 68 commits

• a48b1b8e...0a07cf37 - 64 commits from branch master
• f065c7ba - set geometry mixins automatically, if not defined
• de3d0c26 - `is_yaspgrid` checks itself if the `grid_unstructured` option is set
• a9662160 - removes too strict assertion
• 81014e05 - update some tests

Compare with previous version

Rebased on master after the mixin branch got merge over there.

Hmm, the way of determining that we are using Yasp sounds not really nice.

I have filed core/dune-common#145. Having the problem fixed in dune-common would allow us to have generic as a default.

Based on the currently available options it cannot be decided if you are using yasp grid. So, the only way to determine if yasp grid is used, without adding a new option, is to either check the ini file or the ufl file. May be the check could be more elaborate, but I didn't this would be necessary, since the grid factory has already correctness checks.

Adding a new option for the grid manager may be useful, but for the current problem with the geometry mixin, just using the correct mixin would be simpler.

There is another option to solve the Yaspproblem: Copying the jacobian into a FieldMatrix in the generic code. This would correctly add offdiagonal zeroes. Would that change be sufficient to have us pick generic by default?

I can't think of a reason why that shouldn't be sufficient, until the issue in dune-common is resolved.

Okay, so let's do that! I feel much more comfortable with that!

mentioned in merge request !297 (merged)

Opened a new merge request !297 (merged), which copies the jit into a FieldMatrix.

mentioned in commit c4a14ce5

With !297 (merged) merged, I close this one. Reopen if you disagree.

closed