Skip to content

Add form identifier to timer names

René Heß requested to merge feature/add-form-identifier-to-timer-names into master

If you want to add instrumentation to an example where you generate multiple local operators you get name clashes due to timer names. Adding the form identifier to the timer names gets rid of this problem.

Example: The timers are now called form_identifier_old_identifier, eg. r_transport_alpha_volume_kernel_setup.

Note: This brakes some scripts in dune-codegen/bin so I marked it with WIP. There are two ways to solve this issue:

  1. Adjust the scrips in dune-codegen/bin, use some name manipulation to separate form_name and old_identifier.
  2. It should also be possible to adjust the timer code. Maybe by passing two arguments to HP_DECLARE_TIMER, one with the form_identifier and a second one with the old_identifier (eg alpha_volume_kernel_setup). In order to distinguish the different localoperators in the .csv I would add a new column where I add the form_identifier. In this case adjusting the scripts would be simple.

Instead of the form_identifier I could also use the local operator name.

Any thoughts or opinions? Since this probably breaks your scripts for generating performance numbers I won't do anything before I heard from both of you ;)

Edited by René Heß

Merge request reports