Skip to content
Snippets Groups Projects

use `0` as tag in MPI to avoid too large value

Merged use `0` as tag in MPI to avoid too large value
ansgar/dune-grid-glue:use-lower-tag-for-mpi into master
1 unresolved thread
Merged Ansgar Burchardt requested to merge ansgar/dune-grid-glue:use-lower-tag-for-mpi into master
1 unresolved thread

Some versions of OpenMPI have a lower limit than 12345678; the MPI standard only guarantees values up to at least 32768 are valid.

Closes: #19 (closed)

Merge request reports

Pipeline #29936 passed

Stage: test

Pipeline passed for e307610b on ansgar:use-lower-tag-for-mpi

Approval is optional

Merged by Ansgar BurchardtAnsgar Burchardt 4 years ago (Nov 13, 2020 3:04pm UTC)

Merge details

Pipeline #31171 failed

Stage: test

Pipeline failed for ffa892fb on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
dune/grid-glue/common/ringcomm.hh
221 221 std::array<MPI_Request,N> requests_send;
222 222 std::array<MPI_Request,N> requests_recv;
223 223
224 int tag = 12345678;
224 int const tag = 0;
  • Christian Engwer
    Christian Engwer @christi ·
    Owner

    As mentioned in #19 (closed) I'm not fond of tag = 0. But ... which value should tag have?

  • Ansgar Burchardt added 1 commit

    added 1 commit

    • e307610b - use `0` as tag in MPI to avoid too large value

    Compare with previous version

  • Ansgar Burchardt mentioned in issue #19 (closed)

    mentioned in issue #19 (closed)

  • Ansgar Burchardt mentioned in commit ffa892fb

    mentioned in commit ffa892fb

  • Ansgar Burchardt merged

    merged

    • Please register or sign in to reply