Fixes due to deprecated/removed functions

added 1 commit

91c7b42a - fix missing header include

Thanks! Looks good.

approved this merge request

Hmm... it us unclear to me, why the tests fail, but it fails on all platforms, so there seems to be something really broken.

I assume you tests yourself. Did you run with MPI or without (as this is the first error)?

I'm also a bit puzzled why all the tests fail. On my PC with all modules from their master branch. Locally also with MPI enabled the tests all work.

https://gitlab.dune-project.org/extensions/dune-grid-glue/-/jobs/556969 fails since it ends up in the wrong else branch even for 2.8, even when the code should only take this path for 2.6 and lower.

EDIT: My master branches of dune-common and grid are a bit outdated.

Furthermore, some pipelines file because they cannot pull the docker image, like https://gitlab.dune-project.org/extensions/dune-grid-glue/-/jobs/557192 even when they should still be there: https://gitlab.dune-project.org/docker/ci, don't they. Thanks @christi !

added 1 commit

aebf69ee - test

Compare with previous version

added 1 commit

b2079e86 - test

Compare with previous version

added 1 commit

ae831ab8 - test

Compare with previous version

Ok I investigated a bit and it appears that in https://gitlab.dune-project.org/extensions/dune-grid-glue/-/jobs/557205#L290 the DUNE_GRID version defines don't get expanded. (I wrote that static_assert there for debugging purposes.)

Ok I locally worked with the docker image registry.dune-project.org/docker/ci/dune:2.8-debian-11-gcc-9-20 and try to compile it. I can reproduce the error and it really is the case that the config.h file is not populated only with the dune-grid-glue specific content:

// SPDX-FileCopyrightInfo: Copyright © DUNE Project contributors, see file LICENSE.md in module root
// SPDX-License-Identifier: LGPL-3.0-or-later OR LicenseRef-GPL-2.0-only-with-dune-grid-glue-exception
/* begin dune-grid-glue */

/* Define to the version of dune-grid-glue */
#define DUNE_GRID_GLUE_VERSION "2.10-git"

/* Define to the major version of dune-grid-glue */
#define DUNE_GRID_GLUE_VERSION_MAJOR 2

/* Define to the minor version of dune-grid-glue */
#define DUNE_GRID_GLUE_VERSION_MINOR 10

/* Define to the revision of dune-grid-glue */
#define DUNE_GRID_GLUE_VERSION_REVISION 0

/* end dune-grid-glue */

Therefore, in the code HAVE_MPI and all other stuff like DUNE_<MODULE>_VERSION_MAJOR are not defined. I'm not sure how to fix these things. Maybe @simon.praetorius or @santiago.ospina can you give me a pointer here what is wrong and how to fix it?