#1067 MatrixIndexSet sould use size_type or similar
Metadata
| Property | Value |
|---|---|
| Reported by | Uli Sack (usack@math.fu-berlin.de) |
| Reported at | Apr 13, 2012 10:29 |
| Type | Feature Request |
| Version | Git (pre2.4) [autotools] |
| Operating System | Unspecified / All |
| Last edited by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Last edited at | Apr 15, 2012 08:39 |
| Closed by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Closed at | Apr 15, 2012 08:39 |
| Closed in version | Unknown |
| Resolution | Implemented |
| Comment | The advantage of size_t over int is not just aesthetic, and the chances of breakage are minimal. Patch has been applied in revision 1544. Thanks. |
Description
Is there any specific reason other than "no one ever came around doing it" that MatrixIndexSet uses signed integers for the size parameters rows_ and cols_ as well as as return value for size() rows() etc?
If not I propose using size_t or a typedef size_t size_type.
A corresponding patch is attached.