#1406 alignment of BasicGeometry::mappingStorage_
Metadata
Property | Value |
---|---|
Reported by | Ansgar Burchardt (burchardt@igpm.rwth-aachen.de) |
Reported at | Jan 3, 2014 13:24 |
Type | Bug Report |
Version | Git (pre2.4) [autotools] |
Operating System | Unspecified / All |
Last edited by | Oliver Sander (oliver.sander@tu-dresden.de) |
Last edited at | Apr 14, 2014 07:44 |
Closed by | Oliver Sander (oliver.sander@tu-dresden.de) |
Closed at | Apr 14, 2014 07:44 |
Closed in version | Unknown |
Resolution | Won't fix |
Comment | Closing, because the BasicGeometry class has been removed completely from dune-geometry master. |
Description
BasicGeometry::mappingStorage_ is a char[], but used to store doubles (or other types). However it has the wrong alignment causing failures on sparc[1] and mips[2].
The attached patch adds an alignas(double) which will work for at least the test suite. It could still break in other cases. In addition alignas(...) is C++11.
Ansgar
[1] https://buildd.debian.org/status/fetch.php?pkg=dune-geometry&arch=sparc&ver=2.3~20131228g31cd66f-1&stamp=1388721549 [2] https://buildd.debian.org/status/fetch.php?pkg=dune-geometry&arch=mips&ver=2.3~20131228g31cd66f-1&stamp=1388724040