#1437 DenseMatrix with row_reference != row_type &
Metadata
Property | Value |
---|---|
Reported by | Tobias Malkmus (tomalk@mathematik.uni-freiburg.de) |
Reported at | Feb 27, 2014 10:48 |
Type | Bug Report |
Version | 2.3 |
Operating System | Unspecified / All |
Last edited by | Tobias Malkmus (tomalk@mathematik.uni-freiburg.de) |
Last edited at | Feb 28, 2014 08:51 |
Description
While implementing a densematrix, i stumbled upon several parts where row_reference is assumed to be row_type&
Two patches are attached, which solves the problem for me.
The first patch introduces the class DenseIteratorTraits, which holds the value_type and the reference, needed in the reviewed DenseIterator, which causes the problems. The DenseIteratorTraits for DenseMatrix and DenseVector is implemented and part of the first patch.
The second patch replaced the application of '->' on the iterator with the derefernce of it. This is broken in the iteratorfacde class.
It might not be the best way to over come this problem. Feel free to give hints how to improve this patches.