#1540 [CMake] [Ninja] Allow ninja builds without patching dune-common
Metadata
Property | Value |
---|---|
Reported by | Dominic Kempf (dominic.r.kempf@gmail.com) |
Reported at | Dec 8, 2014 17:28 |
Type | Feature Request |
Version | 2.3 |
Operating System | Unspecified / All |
Last edited by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
Last edited at | Jan 13, 2015 17:56 |
Closed by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
Closed at | Jan 13, 2015 17:56 |
Closed in version | Unknown |
Resolution | Fixed |
Comment | with the help of the Eigen guys. Open source rocks. |
Description
Dear Dune,
for obscure reasons, I have lately become a ninja user. Christoph has described it here: http://users.dune-project.org/projects/main-wiki/wiki/Using_cmake_to_build_your_DUNE_project#Replace-make-by-ninja-build
Patching dune-common is not very nice, so I have written attached patch which turns off the offending line whenever a ninja based generator is used. I have not merged it directly, because it is somehow specific to my extra wishes. Still, I don't see how it could be harmful for other setups and would like it to be merged.
Best, Dominic