#1547 Inifinte recursion in GeometryGrid::leafGridView()
Metadata
Property | Value |
---|---|
Reported by | Jurgis Pods (jurgis.pods@iwr.uni-heidelberg.de) |
Reported at | Dec 18, 2014 15:57 |
Type | Bug Report |
Version | 2.3 |
Operating System | Unspecified / All |
Last edited by | Steffen Müthing (steffen.muething@iwr.uni-heidelberg.de) |
Last edited at | May 12, 2015 13:13 |
Closed by | Steffen Müthing (steffen.muething@iwr.uni-heidelberg.de) |
Closed at | May 12, 2015 13:13 |
Closed in version | Unknown |
Resolution | Fixed |
Comment | Looking at the code, this was fixed ages ago |
Description
I just found a serious bug in GeometryGrid's leafGridView() method, specifically the one templated on a PartitionIteratorType. Code citation:
template< PartitionIteratorType pitype > typename Partition< pitype >::LeafGridView leafGridView () const { return leafGridView(); }
Well, that looks like an infinite recursion. Replacing 'return leafGridView();' by 'return leafView();' fixes this bug (no patch attached).
I came upon this when trying to fix some deprecation warnings and replacing every 'grid.leafView()' with 'grid.leafGridView' in my application. I didn't expect this would break anything, but it did. Internally, GeometryGrid still seems to use leafView() by default, so it would be nice if this could be fixed as well to get rid of all the deprecation warnings.