#925 Consistent Coding Style in the Core Modules
Metadata
| Property | Value |
|---|---|
| Reported by | Andreas Lauser (andreas.lauser@iws.uni-stuttgart.de) |
| Reported at | May 30, 2011 16:43 |
| Type | Bug Report |
| Version | 2.0 |
| Operating System | Unspecified / All |
| Last edited by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Last edited at | Apr 18, 2012 16:23 |
| Closed by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Closed at | Apr 18, 2012 16:23 |
| Closed in version | Unknown |
| Resolution | Deferred |
| Comment | We are talking about serious changes to the interface. Nothing of this sort can be done without discussion and explicit consent by a large majority of the developers. Which is not to say that it is a bad proposal. Still, closing as 'deferred'. |
Description
Hi All,
Today I was sufficiently annoyed of the inconsistencies in the variable/typedef/constant naming that I decided to do something about it. According to
http://www.dune-project.org/doc/devel/codingstyle.html
every thing should use CamelCase and underscores are not allowed except to mark an attribute as private. In the current version of some DUNE core modules (most notably dune-common and dune-istl) the situation is quite different. The attached patch against the 2.1 branch fixes this issue for most of the dense vector/matrix stuff in dune-common by adding CamelCase names and deprecating the old names. All my code still compiles and runs without any modifications, albeit quite a few warnings appear when compiling it. I know this patch is far from complete, I just wanted to start somewhere and I want to hear a few options from actual dune developers. If it is decided that this is the way to go, I will provide complete patches for all core dune modules...