Make sure that the relaxation factor for smoothers never is complex.
The note /dune-istl/dune/istl/paamg/smoother.hh:130:26: note: the ABI of passing structure with complex float member has changed in GCC 4.4 for DefaultConstructionArgs::getArgs got me thinking. I just could not imagine why there should be comlex value involved. Turned out we somehow assumed that for complex the relaxation factore would be complex, too. IMHO a relaxation factor should scale and hence be real. This MR make ssure that the relaxation factor is never complex. Unforntunately, then a note for std::make_pair with a complex in repartition.hh appeared: /usr/include/c++/8/bits/stl_pair.h:524:5: note: the ABI of passing structure with complex float member has changed in GCC 4.4 make_pair(_T1&& __x, _T2&& __y) and I just resorted to constructing Pair directly. Not sure whether this is really needed but it should not hurt and ensures more silence.
Showing
- dune/istl/matrixredistribute.hh 3 additions, 3 deletionsdune/istl/matrixredistribute.hh
- dune/istl/paamg/smoother.hh 2 additions, 1 deletiondune/istl/paamg/smoother.hh
- dune/istl/preconditioners.hh 34 additions, 20 deletionsdune/istl/preconditioners.hh
- dune/istl/test/complexrhstest.cc 1 addition, 1 deletiondune/istl/test/complexrhstest.cc
Loading
Please register or sign in to comment