Fix warning with target_link_libraries

cmake/modules/AddARPACKPPFlags.cmake

@@ -13,7 +13,7 @@
 function(add_dune_arpackpp_flags _targets)
   if(ARPACKPP_FOUND)
     foreach(_target ${_targets})
-      target_link_libraries(${_target} ${ARPACKPP_DUNE_LIBRARIES})
+      target_link_libraries(${_target} PUBLIC ${ARPACKPP_DUNE_LIBRARIES})
       target_compile_definitions(${_target} PUBLIC ENABLE_ARPACKPP=1)
       target_compile_options(${_target} PUBLIC ${ARPACKPP_DUNE_COMPILE_FLAGS})
     endforeach()

cmake/modules/AddSuperLUFlags.cmake

@@ -33,7 +33,7 @@ endif()
 function(add_dune_superlu_flags _targets)
   if(SuperLU_FOUND)
     foreach(_target ${_targets})
-      target_link_libraries(${_target} SuperLU::SuperLU)
+      target_link_libraries(${_target} PUBLIC SuperLU::SuperLU)
       target_compile_definitions(${_target} PUBLIC ENABLE_SUPERLU=1)
     endforeach()
   endif()

dune/istl/eigenvalue/test/CMakeLists.txt

 add_executable(poweriterationtest cond2test.cc)
-target_link_libraries(poweriterationtest dunecommon)
+target_link_libraries(poweriterationtest PRIVATE dunecommon)
 dune_add_test(
   TARGET poweriterationtest
   CMD_ARGS 40)
@@ -10,13 +10,13 @@ if(SuperLU_FOUND)
   dune_add_test(
     TARGET poweriterationsuperlutest
     CMD_ARGS 40)
-  target_link_libraries(poweriterationsuperlutest dunecommon)
+  target_link_libraries(poweriterationsuperlutest PRIVATE dunecommon)
 endif()
 
 if(ARPACKPP_FOUND)
   add_executable(arpackpptest cond2test.cc)
   add_dune_arpackpp_flags(arpackpptest)
-  target_link_libraries(arpackpptest dunecommon)
+  target_link_libraries(arpackpptest PRIVATE dunecommon)
   dune_add_test(TARGET arpackpptest)
 endif()
 

dune/istl/paamg/test/CMakeLists.txt

@@ -2,20 +2,20 @@ find_package(Threads)
 if(CMAKE_USE_PTHREADS_INIT)
   add_executable(pthreadamgtest pthreadamgtest.cc)
   target_compile_definitions(pthreadamgtest PUBLIC MYAMG=Dune::Amg::AMG<Operator,Vector,Smoother>)
-  target_link_libraries(pthreadamgtest ${CMAKE_THREAD_LIBS_INIT} ${DUNE_LIBS})
+  target_link_libraries(pthreadamgtest PRIVATE ${CMAKE_THREAD_LIBS_INIT} ${DUNE_LIBS})
   add_dune_mpi_flags(pthreadamgtest)
   add_dune_parmetis_flags(pthreadamgtest)
   dune_add_test(TARGET pthreadamgtest)
 
   add_executable(pthreadfastamgtest pthreadamgtest.cc)
   target_compile_definitions(pthreadfastamgtest PUBLIC MYAMG=Dune::Amg::FastAMG<Operator,Vector>)
-  target_link_libraries(pthreadfastamgtest ${CMAKE_THREAD_LIBS_INIT} ${DUNE_LIBS})
+  target_link_libraries(pthreadfastamgtest PRIVATE ${CMAKE_THREAD_LIBS_INIT} ${DUNE_LIBS})
   add_dune_mpi_flags(pthreadfastamgtest)
   add_dune_parmetis_flags(pthreadfastamgtest)
   dune_add_test(TARGET pthreadfastamgtest)
 
   add_executable(pthreadtwoleveltest pthreadtwoleveltest.cc)
-  target_link_libraries(pthreadtwoleveltest ${CMAKE_THREAD_LIBS_INIT} ${DUNE_LIBS})
+  target_link_libraries(pthreadtwoleveltest PRIVATE ${CMAKE_THREAD_LIBS_INIT} ${DUNE_LIBS})
   add_dune_mpi_flags(pthreadtwoleveltest)
   add_dune_parmetis_flags(pthreadtwoleveltest)
   dune_add_test(TARGET pthreadtwoleveltest)
@@ -40,27 +40,27 @@ endif()
 
 # add an executable without SuperLU/UMFPack
 add_executable(amgtest amgtest.cc)
-target_link_libraries(amgtest ${DUNE_LIBS})
+target_link_libraries(amgtest PRIVATE ${DUNE_LIBS})
 add_dune_mpi_flags(amgtest)
 add_dune_parmetis_flags(amgtest)
 dune_add_test(TARGET amgtest)
 
 add_executable(fastamg fastamg.cc)
-target_link_libraries(fastamg ${DUNE_LIBS})
+target_link_libraries(fastamg PRIVATE ${DUNE_LIBS})
 add_dune_mpi_flags(fastamg)
 add_dune_parmetis_flags(fastamg)
 dune_add_test(TARGET fastamg)
 
 if(SuperLU_FOUND)
   add_executable(superluamgtest amgtest.cc)
-  target_link_libraries(superluamgtest ${DUNE_LIBS})
+  target_link_libraries(superluamgtest PRIVATE ${DUNE_LIBS})
   add_dune_superlu_flags(superluamgtest)
   add_dune_mpi_flags(superluamgtest)
   add_dune_parmetis_flags(superluamgtest)
   dune_add_test(TARGET superluamgtest)
 
   add_executable(superlufastamgtest fastamg.cc)
-  target_link_libraries(superlufastamgtest ${DUNE_LIBS})
+  target_link_libraries(superlufastamgtest PRIVATE ${DUNE_LIBS})
   add_dune_superlu_flags(superlufastamgtest)
   add_dune_mpi_flags(superlufastamgtest)
   add_dune_parmetis_flags(superlufastamgtest)