Add getters and setters to NewtonSolver interfaces
requested to merge lukas.riedel/dune-pdelab:add-getters-and-setters-to-newton-interfaces into master
What does this MR do?
This MR improves accessibility of some internal structures of the new NewtonSolver. Specifically, the instances of TerminateInterface and LineSearchInterface used in a NewtonSolver object can now be retrieved from it. Additionally, DefaultTerminate now implements single setters for its parameters.
I also removed the unconditional output of the maximum iterations from the DefaultTerminate::setParameters() method.
I updated the testnewton.cc test accordingly.
Open Questions
- Setting the maximum iterations for
NewtonSolvernow is a bit easier, but it still requires a downcast fromTerminateInterfacetoDefaultTerminate(as done in the test). Is there a better way to do this?
Related Issues
Closes #167 (closed)
Edited by Lukas Riedel