Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • D dune-testtools
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 11
    • Issues 11
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DuneQuality
  • dune-testtools
  • Merge requests
  • !80

[bugfix] Use more robust implementation of conditional evaluation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dominic Kempf requested to merge feature/stabilize-conditional-parsing into master Jul 11, 2016
  • Overview 3
  • Commits 2
  • Changes 2

Our previous way of implementing conditional evaluation was really dirty. This one is definitely bit better, though the whole concept of avoiding single quotes in conditionals is still a bit weird.

The old implementation failed spectacular trying to evaluate a condition along the lines of 'x==x and x==x', where the third x somehow did not match in the parser.

Thanks to @eike.mueller for pointing out the original issue.

This fixes #113 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/stabilize-conditional-parsing