Skip to content

remove virtual from type_info member function

Simon Praetorius requested to merge simon.praetorius/dune-functions:issue/typeerasurebase_typeinfo into master

Summary

The MR removes the virtual specifier from the member-function type_info in TypeErasureBase to eliminate a segfault when using the type-erasure classes.

Details

The virtual keyword is not necessary in the definition of that member function. The class is also not made virtual by providing a virtual destructor. So, this virtual is a general defect of that class.

This MR is a consequence of the mailinglist report, see https://lists.dune-project.org/pipermail/dune-functions/2020-July/000245.html

A simple test to reproduce the segfault can be found in https://gitlab.dune-project.org/snippets/56

Edited by Simon Praetorius

Merge request reports