Skip to content

Draft: Cleanup implementation of grid-functions

Simon Praetorius requested to merge feature/cleanup-grid-functions into master

Summary

This is an extraction of some code changes from !345 (merged) to improve the readability and consistency of the code in the directory gridfunctions/

Major stylistic changes

  • Use class instead of typename in templates
  • Use std::size_t instead of unprefixed size_t
  • No spaces between function name and argument list
  • Spaces around assignment = sign
  • Prefer using over typedef
  • If possible (and not automatically provided) write deduction guide for class templates

Not consistently enforced styles

Other changes

  • Implement global evaluation function for CompositeGridFunction.
  • Move implementation detail closestFaceIndex into the class FaceNormalGridFunction where it is used.
Edited by Simon Praetorius

Merge request reports