Skip to content
Snippets Groups Projects

Stabilize ddd type definitions

Merged Oliver Sander requested to merge stabilize-ddd-type-definitions into master
All threads resolved!

Some cleanup of the ddd type definition code.

As a by-product, this should fix !166 (closed).

Edited by Oliver Sander

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I added a commit (in my fork, I can't push here) which finishes fixing the undefined behavior. Clang-10 with -fsanitize=undefined -fno-sanitize-recover=undefined now does not report any undefined behavior in typemgr.cc or initddd.cc (it still does in gm/gm.h, gm/enrol.cc and gm/ugm.cc).

    Instead of casting the desc->bnd_size and desc->inner_size to size_t, we could also just change their type to size_t, but I wasn't sure if that would cause some problems elsewhere.

  • Thank you, I ran out of time to finish this MR yesterday. I'll finish and merge it no later than monday.

  • (it still does in gm/gm.h, gm/enrol.cc and gm/ugm.cc).

    Can you open a separate issue for that, with some more information?

  • Oliver Sander added 2 commits

    added 2 commits

    • 9763bfa9 - Make DDD_TypeDefine accept member offsets rather than member pointers
    • 0cd0df3e - Fix a few simple compiler warnings

    Compare with previous version

  • Oliver Sander changed the description

    changed the description

  • Oliver Sander resolved all threads

    resolved all threads

  • Oliver Sander unmarked as a Work In Progress

    unmarked as a Work In Progress

  • merged

  • Oliver Sander mentioned in commit 27443346

    mentioned in commit 27443346

  • Please register or sign in to reply
    Loading