Link dunecommon to duneuggrid lib

Fixes #55 (closed).

I get a linker error when compiling with AppleClang a fresh dune installation, all master branch, see #55 (closed). Doesn't appear to be a problem on Linux with gcc and clang.

This MR fixes the linker error. Is there a better way to do this? @simon.praetorius?

changed the description

Maybe the linker error in core/dune-grid#137 (closed) is related?

I think, duneuggrid should be linked against dunecommon, because it is a direct dependency. I'm just not sure why this is not already the case. I need to check...

I checked the difference of the linker command (when Linking CXX shared library lib/libduneuggrid.dylib) between this branch and master (VERBOSE=1). On this branch there is additionally the flags

-Wl,-rpath,/Users/pumbaa/dune-test-master/dune-common/build-cmake/lib /Users/pumbaa/dune-test-master/dune-common/build-cmake/lib/libdunecommon.dylib -framework Accelerate -lm -ldl /usr/local/lib/libtbb.dylib

(obtained with git diff --color-words --no-index -- master.log explicitlinking.log) apart from that the command is identical. dune-common doesn't occur at all on master, so dune-common is definitely not linked correctly. Full commands are attached. master.log thisbranch.log

@simon.praetorius I also identified the offending commit as your commit 53e98110 from a year ago. Before everything linked correctly, afterwards the linker error. Seems like in that very confusing code that was there before your cleanup commit, dune-common was linked somewhere.

mentioned in issue #55 (closed)

added 1 commit

• fd8e9071 - Link dunecommon to duneuggrid lib

Compare with previous version

resolved all threads

added 3 commits

• fd8e9071...37396602 - 2 commits from branch staging:master
• 1b1ac4d3 - Link dunecommon to duneuggrid lib

Compare with previous version

I think this can be merged.

merged

mentioned in commit 441e25fe