Fix a couple of cppcheck findings (!227) · Merge requests · staging / dune-uggrid · GitLab

Snippets Groups Projects

Merged Christoph Grüninger requested to merge feature/fix-some-cppcheck-findings into master 1 year ago

Nov 05, 2023
- Declare loop variables inside of for loop · 515c0ef3
  Christoph Grüninger authored 1 year ago
  
  This prevents shadowing of i and j Found by cppcheck
  515c0ef3
- Prevent possible null pointer dereference of variable theGrid · b9b97dc7
  Christoph Grüninger authored 1 year ago
  
  Move dereference after NULL check Found by cppcheck
  b9b97dc7
- Do not shadow variable · cc5197c7
  Christoph Grüninger authored 1 year ago
  
  Found by cppcheck
  cc5197c7
- Rename local variable and avoid usind shadowed variable · 564518d6
  Christoph Grüninger authored 1 year ago
  
  Rename i to rule to use proper variable in debug output. This was found by cppcheck
  564518d6
- Fix calculation of debug output · 66c60b4f
  Christoph Grüninger authored 1 year ago
  
  Instead of printing the total of inspected elements, the code just pointed one element after the array. Add proper code to sum up the number of inspected elements. This was found by cppcheck
  66c60b4f
Nov 04, 2023
- Fix out of bounds array access · 6b8a3bcf
  Christoph Grüninger authored 1 year ago
  
  After the for loop, i is beyond the last element. Founc by cppcheck
  6b8a3bcf
- [cleanup] Remove unused pointer freeSegmentsPerPoint · c236468f
  Christoph Grüninger authored 1 year ago
  
  Saves a memory allocation. Found by cppcheck
  c236468f