Skip to content

Improve support for MSVC

Santiago Ospina De Los Ríos requested to merge feautre/msvc-support into master

I get two kind of errors when building against MSVC:

  1. Usage of M_PI. This can be changed by Dune::StandardMathematicalConstants<double>::pi()
  2. Usage of mode_t Linux file descriptors. This seems to be only used by mkdir_r, so an option is to re-wreite this function in terms of C++17 permissions: std::filesystem::permissions.

Here a CI with the errors: https://github.com/SoilRos/dune-super-build/actions/runs/11943956849/job/33294007415

Merge request reports