Skip to content
Snippets Groups Projects

[cmake] Require CMake 3.1

Merged Christoph Grüninger requested to merge feature/bump-cmake-to-3.1 into master
  • Follow Dune core modules 2.6.
  • Prevents CMake warning when using dune-common 2.6.

Unless you want to stay compatible with Dune 2.5 and keep its lower required CMake version.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • is there a feature in dune-uggrid, which requires the newer cmake?

  • Not as far as I know. But @ansgar may know ways to simplify the uggrid cmake code if a newer cmake is mandatory.

  • None of the core modules needs 3.1. (Well, some only require 2.8.12). So why we raise the bar for no reason is beyond me.

  • I always though that some features require newer cmake.

    If htis is ot the case we should go back to a lower requirement. While I don't think we need to stick to old infrastructure, we should also not raise the barrier for no reason.

  • Regarding Markus: There was a decision to require CMake 3.1 for Dune 2.6. At some places we had workaround for bugs that I removed because we require now 3.1. Going back to 2.8.12 you have to restore those parts and check whether you have to fix other bugs in newly added code.

    Regarding Christion: Within dune-uggrid you are probably right, there might be no CMake 3.1+ code in this module. But code from dune-common is executed, but with a diverging minimal required CMake version. As a consequence some policies are set differently, this might trigger subtle bugs and cause some warning. That's why I state, if you want to use dune-uggrid with dune-common, better require CMake 3.1. On the other hand, what harm is done, if dune-uggrid requires CMake 3.1 even if run together with Dune 2.5? PDELab went the same road already for 2.5.

  • Ansgar Burchardt removed milestone

    removed milestone

  • mentioned in commit fcc8a34d

Please register or sign in to reply
Loading