1. 19 Nov, 2019 8 commits
    • Oliver Sander's avatar
      [!127] Fix warnings unused function · edf4d675
      Oliver Sander authored
      Merge branch 'fix_warnings_unused_function' into 'master'
      
      ref:staging/dune-uggrid Added preprocessor if-conditions and commented out
      some unused functions to avoid compiler warnings made by CI test
      "gcc-7-14-sequential".
      
      See merge request [!127]
      
        [!127]: gitlab.dune-project.org/staging/dune-uggrid/merge_requests/127
      edf4d675
    • Henrik Stolzmann's avatar
      Fixed warning: "unused-function" "CheckNodeContext" · 0efc9725
      Henrik Stolzmann authored
      Deleted the function "CheckNodeContext" because it was not used in.
      ````
      static INT CheckNodeContext (ELEMENT *theElement, NODE ** NodeContext)
      {
        INT i, mark,nor,noc;
      
        mark = MARK(theElement);
        for (i=CORNERS_OF_ELEM(theElement); i<CORNERS_OF_ELEM(theElement)+EDGES_OF_ELEM(th       eElement); i++)
        {
          if (NODE_OF_RULE(theElement,mark,i-CORNERS_OF_ELEM(theElement))) nor = 1;
          else nor = 0;
          if(NodeContext[i]!=NULL) noc = 1;
          else noc = 0;
          if(nor!=noc)
            if (GetNodeContext(theElement,NodeContext)) REP_ERR_RETURN(1);
        }
        for (; i<CORNERS_OF_ELEM(theElement)+EDGES_OF_ELEM(theElement)+SIDES_OF_ELEM(theEl       ement); i++)
          if (NodeContext[i]!=NULL)
            if (GetNodeContext(theElement,NodeContext)) REP_ERR_RETURN(1);
      
        return (0);
      }
      ````
      0efc9725
    • Henrik Stolzmann's avatar
      Fixed warning: "unused-function" caused by "CheckLocalElementKeys" · 87031df0
      Henrik Stolzmann authored
      Deleted the definition of "CheckLocalElementKeys" for the case
      ````
      !(MGIO_DEBUG>0)
      ````
      because all uses in this file are contained in a preprocessor if condtion ensuring
      that
      ````
      MGIO>0
      ````
      87031df0
    • Henrik Stolzmann's avatar
      Deleted function "PrintEdgeInfo" as agreed. · 20d0629d
      Henrik Stolzmann authored
      The function was not needed.
      20d0629d
    • Henrik Stolzmann's avatar
      Fixed warning: "unused-function" caused by "Write_RefRules" · 4e66145e
      Henrik Stolzmann authored
      Added a preprocessor if condition around the definition of
      "Write_RefRules" because it is used in such an environment.
      ````
      static INT Write_RefRules (MULTIGRID *theMG, INT *RefRuleOffset, INT MarkKey)
      {
        ...
      }
      ````
      
      Furthermore there is a comment adressing the only use of "Write_RefRules".
      
      ````
      /* TODO (HRR 971209): drop old call of Write_RefRules */
        #if EXTRACT_RULES
      if (NEW_Write_RefRules(theMG,rr_rule_offsets,MarkKey,&rr_rules)) REP_ERR_RETURN(1)       ;
            #else
      if (Write_RefRules(theMG,rr_rule_offsets,MarkKey)) REP_ERR_RETURN(1);
            #endif
      ````
      But i am not sure whether "Write_RefRules" is still needed.
      4e66145e
    • Henrik Stolzmann's avatar
      Fixed warning: "unused-function" "FillSonPaths" · 83559ffd
      Henrik Stolzmann authored
      Added a preprocessor if conditon around the definition of "FillSonPaths"
      because the only use in this file is contained in such an if condition.
      ````
       #ifdef __THREEDIM__
      static void FillSonPaths (MGIO_RR_RULE *rule)
      {
      
       ...
      
      }
       #endif
      ````
      
      ````
              #ifdef __THREEDIM__
        /* 2D: not even in rm */
        /* son path */
        FillSonPaths(mr);
              #endif
      ````
      83559ffd
    • Henrik Stolzmann's avatar
      Fixed warning: "unused-function" for "RuleCompare" · cf8fcc15
      Henrik Stolzmann authored
      I added a preprocessor if-condition to the definition of "RuleCompare"
      because the only use in "gm/er.cc" is contained in such an environment in line 698
      
      ````
       #ifdef __DEBUG_ER__
      static INT RuleCompare (int id, const URULE *ur, const ERULE *er)
      {
        ...
      }
       #endif
      ````
      
      ````
              #ifdef __DEBUG_ER__
        ...
        RuleCompare(ID(elem),ur,er);
        ...
              #endif
      ````
      cf8fcc15
    • Henrik Stolzmann's avatar
      Fixed a compiler warning: "unused function" · d36a00ab
      Henrik Stolzmann authored
      I added a preprocessor environment to contain the definiton of the
      function: "CheckElementContextConsistency"
      
      ````
       #ifdef Debug
      static void CheckElementContextConsistency( arguments )
      {
      
       ...
      
      }
       #endif
      ````
      because the following use of the function is also contained in such an
      environment.
      d36a00ab
  2. 18 Nov, 2019 1 commit
  3. 09 Nov, 2019 2 commits
    • Oliver Sander's avatar
      [!141] Rentroduce Vector::skip as Vector::leafIndex · 172f6988
      Oliver Sander authored
      Merge branch 'fix-vector-leaf-index' into 'master'
      
      ref:staging/dune-uggrid The 'skip' data member of the Vector class used to be
      abused for the leaf index of the vector, if that vector corresponds to an
      element facet in 3d. By accident, that 'skip' field got removed in a recent
      commit. Let's put it back in, but rename it to 'leafIndex' now. All it is used
      for nowadays is that leaf index.
      
      See merge request [!141]
      
        [!141]: gitlab.dune-project.org/staging/dune-uggrid/merge_requests/141
      172f6988
    • Oliver Sander's avatar
      Rentroduce Vector::skip as Vector::leafIndex · 0ea5bc24
      Oliver Sander authored
      The 'skip' data member of the Vector class used to be abused for
      the leaf index of the vector, if that vector corresponds to an
      element facet in 3d.  By accident, that 'skip' field got removed
      in a recent commit.  Let's put it back in, but rename it to
      'leafIndex' now.  All it is used for nowadays is that leaf index.
      0ea5bc24
  4. 06 Nov, 2019 2 commits
    • Oliver Sander's avatar
      [!139] Removed data member vector::skip · 4b4e02a9
      Oliver Sander authored
      Merge branch 'master' into 'master'
      
      ref:staging/dune-uggrid Removed vector::skip and the code that uses it. It
      compiles and the few existing tests run without problems.
      
      Fixes [#29]
      
      See merge request [!139]
      
        [#29]: gitlab.dune-project.org/NoneNone/issues/29
        [!139]: gitlab.dune-project.org/staging/dune-uggrid/merge_requests/139
      
      
      Closes #29
      4b4e02a9
    • Henrik Stolzmann's avatar
      Removed data member vector::skip · 77cb8422
      Henrik Stolzmann authored
      See Issue `#29`.
      Removed `vector::skip` and the  code that uses it. It compiles and the
      few existing tests run without problems.
      77cb8422
  5. 08 Oct, 2019 1 commit
  6. 04 Oct, 2019 1 commit
  7. 23 Sep, 2019 1 commit
  8. 04 Sep, 2019 2 commits
  9. 10 Jul, 2019 4 commits
  10. 09 Jul, 2019 3 commits
  11. 29 Jun, 2019 2 commits
  12. 19 Jun, 2019 2 commits
  13. 18 Jun, 2019 8 commits
  14. 13 Jun, 2019 1 commit
  15. 27 May, 2019 2 commits