Skip to content
Snippets Groups Projects
Forked from Core Modules / dune-common
Source project has a limited visibility.
  • Oliver Sander's avatar
    405797ed
    Fix Andreas' previous patch · 405797ed
    Oliver Sander authored
    I shouldn't be doing patch reviews after 2300
    
    Here is Andreas' commit message:
    
    >From 1049843fa0dbc6b340817b0cd69959e742e80d7a Mon Sep 17 00:00:00 2001
    From: Andreas Lauser <Andreas.Lauser@iws.uni-stuttgart.de>
    Date: Wed, 6 Feb 2013 23:33:28 +0100
    Subject: [PATCH] once again: fix dune_unused.m4
    
    my previous attempt was only partially correct: the compiler did not
    chocke because the unused attribute was placed behind the variable,
    but because the third argument of AC_TRY_COMPILE is placed inside the
    main function. it seems like c++ does not support nested functions, so
    the test still failed, leading to the equally undesired result that
    DUNE_UNUSED did not have an effect anymore. Mea culpa!
    
    (this time I have at least double verified, that the compiler does not
    bail out. last time I probably mis-interpreted the wrong lines as the
    output of the dune_unused test in config.log.)
    
    
    [[Imported from SVN: r7106]]
    405797ed
    History
    Fix Andreas' previous patch
    Oliver Sander authored
    I shouldn't be doing patch reviews after 2300
    
    Here is Andreas' commit message:
    
    >From 1049843fa0dbc6b340817b0cd69959e742e80d7a Mon Sep 17 00:00:00 2001
    From: Andreas Lauser <Andreas.Lauser@iws.uni-stuttgart.de>
    Date: Wed, 6 Feb 2013 23:33:28 +0100
    Subject: [PATCH] once again: fix dune_unused.m4
    
    my previous attempt was only partially correct: the compiler did not
    chocke because the unused attribute was placed behind the variable,
    but because the third argument of AC_TRY_COMPILE is placed inside the
    main function. it seems like c++ does not support nested functions, so
    the test still failed, leading to the equally undesired result that
    DUNE_UNUSED did not have an effect anymore. Mea culpa!
    
    (this time I have at least double verified, that the compiler does not
    bail out. last time I probably mis-interpreted the wrong lines as the
    output of the dune_unused test in config.log.)
    
    
    [[Imported from SVN: r7106]]