Marco Agnese authored 9 years ago and Jö Fahlke committed 9 years ago

Use std::array instead of Dune::array.
[make_array] use variadic template instead of different specialization

This has to be done as each module puts dune-common_MODULE_PATH into
CMAKE_MODULE_PATH to find the DUNE's cmake macros. This should be removed
when building the complete CMAKE_MODULE_PATH module path (in reverse order
of the dependency). Unfortunately, the conditional to check whether
the variable dune-common_MODULE_PATH is set was incorrect. This commit fixes
this.

I hope that this fixes FS 1686
https://dune-project.org/flyspray/index.php?do=details&task_id=1686

Please merge to the release

- add question concerning configure options
- add question concerning disabling options
- mention deletion of CMakeCache.txt

Update CXXFLAG question.
More proof reading and line wrapping.

- Get rid of \\ at end of paragraphs
- Fix various misspellings
- add some convenience macros
- add myself as co-author
- break long lines which were modified anyway

Commit 4878943f actuall did change
the default behavior, it effectifly disabled LaTex for some users.
To disable LaTeX pass -DCMAKE_DISABLE_FIND_PACKAGE_LATEX=TRUE

* feature/FS1683-improve-iteratorrange:
  [IteratorRange][Release] Make IteratorRange default-constructible and copyable

IteratorRanges are convenient for storing ranges of iterators into a
larger container, e.g. for the per-codim GeometryTypes in an
IndexSet. Unfortunately, you can't just create an array of
IteratorRanges right now because they can neither be copied, nor are
they default-constructible.

This patch fixes that problem and also adds a second typedef
const_iterator to make IteratorRange work in contexts where the
iterating code isn't using range-based for and assumes a const object.

Otherwise it collides with the config.h.cmake for in-source builds.
The generated file is called config_collected.h.cmake.
Thanks to Robert for the heads-up.

Setting a policy must be guarded as older CMake version do not
know about the policy.

CMake >= 2.8.12 can optionally use @rpath to embed dynamic linker paths
into shared libraries on OS X. This greatly improves reliability with
libraries in non-standard locations and should definitely be turned on
by default.

script. This feature is disabled by default and can be enabled by
-DALLOW_CXXFLAGS_OVERWRITE=ON.

This branch fixes a number of problems related to
dune_enable_all_packages():

- The feature requires at least CMake 2.8.12, which is more recent than
  the baseline requirement of the core modules (2.8.12). We now check
  for that when executing the relevant functions and also remind the
  user to set the correct version in cmake_minimum_required().
- Updated the documentation to also state the version requirement.
- The duneproject script now also warns the user about the more
  stringent CMake version requirements when using the feature and sets
  the correct minimum required CMake version in the new module's main
  CMakeLists.txt file.
- There was a bug in duneproject that caused it to always enable
  dune_enable_all_packages(), ignoring the choice made by the user. That
  bug is fixed in this branch.
- Some minor fixes to duneproject while I was at it.

This fixes FS1678.

* feature/FS1678:
  [dunecontrol] Output choice of external package handling and required CMake version
  [duneproject] Allow specifying ENABLE_ALL as 5th command line argument
  [duneproject] Update CMake minimum version if ENABLE_ALL is true
  [duneproject][Bugfix] Make sure dune_enable_all_packages() can actually be disabled
  [CMake] Improve documentation in DuneEnableAllPackages.cmake
  [CMake][Doc] Add required CMake version to dune_enable_all_packages()
  [CMake] Require CMake 2.8.12 for dune_enable_all_packages()
  [CMake] Fix typo in warning message.
  Add a warning that some functions are 2.8.12

With the recent changes to bigunsignedint, the index cannot
be initialized with a negative value anymore. We change this
to 1 to overcome the problem.

This commit together with the recent bugfixes by Ansgar
fixes the AMG code on master.

dune_enable_all_packages() now requires CMake 2.8.12, so make sure
duneproject generates a correct template.

Also output a warning to tell the user about this change in required
CMake version.

The shell script logic for switching dune_enable_all_packages() on or
off in duneproject was broken and always turned the feature on, ignoring
the user input.

Fixed by testing for the actual contents of the variable instead of its
length and by converting the contents to lowercase before.

Since 0c697d8d messages of size zero
are no longer sent. This can reduce the number of requests we have to
wait for.

The storage of bigunsignedint was changed to std::uint16_t in commit
541b3dfc. This implements the same
change for the MPITraits<bigunsignedint<k>>

Note that this assumes that
  MPITraits<std::uint16_t>
is defined. This is the case as long as uint16_t maps to one of the
standard integer types (unsigned char/short/int/long).

Thanks to Markus for pointing this out.

Reference: https://dune-project.org/flyspray/index.php?do=details&task_id=1657#comment6393

All the functionality in DuneEnableAllPackages.cmake is now contained in
functions instead of macros. Update the documentation to reflect that.

State the minimum required version of CMake in the documentation for
dune_enable_all_packages() and dune_target_enable_all_packages().

dune_enable_all_packages has to update the compiler options, but the
command compile_options only exists in CMake 2.8.12+. So we add a hard
requirement for that CMake version to the function.

I only ever intended this feature to work for CMake >= 2.8.12, so this
doesn't really change anything, except for giving the users a more
useful diagnostic.

Minimum required CMake version is 2.8.12 and not 2.9.12.

The duncontrol / dune.module mechanism allowes to overload the run_* commands, which
are executed in order to setup/build/etc. a module. This patch fixes a bug in the cmake
parsing of the dune.module file. Somehow cmake tried to interpret the content of the
dune.module as cmake code. We now use a different strategy to parse the file and avoid
storing the content in a temporary variable.

>> please backport to 2.4

This bug could only be found outside Germany :D

This document gathers some beginners question about the CMake
build system. It is built during make doc and made available
on the website through the doc installation.