Thanks for spotting that, Dominic!

(cherry picked from commit c849d756)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

This branch resolves somes smaller problems with the
dune_enable_all_packages() feature and importantly provides support for
modules with libraries and CMake < 3.1.

* feature/FS1654-improve-dune-enable-all-packages:
  [Release][CMake] Add support for compile options in DuneEnableAllPackages
  [Release][CMake][Bugfix] Use correct test in if() command
  [Release][CMake] Add dune_target_enable_all_packages()
  [Release][CMake][Bugfix] Remove stray unset() command
  [Release][CMake] Convert macros to functions in DuneEnableAllPackages
  [Release][CMake] Improve documentation in DuneEnableAllPackages.cmake

(cherry picked from commit 7cc5bc4b)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

We do not really support this combination of C++11 features, and the
only time it should occur is when the user has a recent Intel Compiler
and an outdated GCC (which the Intel Compiler uses for the C++ standard
library). In that case, we emit a helpful error message at configuration
time.

(cherry picked from commit c3e637ab)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

The std::numeric_limits specialization for bigunsignedint requires
access to the internal state of bigunsignedint. Previously, the correct
specialization of std::numeric_limits was a friend of bigunsignedint,
but that creates problems on recent versions of clang with the
alternative libc++ library, because that library declares the base
template of std::numeric_limits as a class and clang subsequently
complains if the friend declaration uses 'struct'. Unfortunately,
libstdc++ uses a struct, making it impossible to keep clang happy for
both standard libraries. So we introduce a helper class that provides
access to the internal state and which now becomes a friend of
bigunsignedint. The numeric_limits specialization inherits from the
helper to use it.

(cherry picked from commit a7951dff)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

(cherry picked from commit e9634076)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

According to the standard, all specializations of std::hash must export
argument_type and result_type [20.8.12/1]. The version of libc++ (LLVM's
alternative C++ standard library) tripped over this requirement on my
machine, so this patch adds the typedefs.

(cherry picked from commit a64ca159)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

Ansgar fixed a bunch of problems in bigunsignedint - and improved the
corresponding test! yeah!

* p/ansgar/FS1644-bigunsignedint:
  Rework bigunsignedinttest.cc.
  bigunsignedint: Remove unneeded variable in operator%.
  bigunsignedint: Fix operator-.
  bigunsignedint: Throw an exception when constructing from a negative integer.
  bigunsignedint: make overload unambiguous for all integer types
  Use fixed-width integer types (C++11)

(cherry picked from commit 4c79a644)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

The test for __cxa_demangle(), which is used by Dune::className() to
demangle type names, doesn't work on my clang 3.6. Apparently, clang
requires the user to include <typeinfo> before <cxxabi.h>. While
classname.hh already does this, the build system tests don't, causing the
feature to get disabled on clang.

Fixed by adding the include to the build system tests.

(cherry picked from commit 70f52c0d)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

This only contains commits that:
* were already cherry-picked
* were requests to be cherry-picked by Ansgar
  in preparation for integration into debian

Merge remote-tracking branch 'origin/feature/fix-variablesizecom-with-empty-interface' into releases/2.4

Merge on request of Markus Blatt

Claus-Justus Heine authored 9 years ago and Christoph Grüninger committed 9 years ago

Although GNU find may allow to omit the directory
argument, an ordinary (e.g. BSD) find does not.

DuneEnableAllPackages.cmake, FindThreadsCMake31.cmake and
CheckForPthreads.c were missing in the Dune-common installation.

Ansgar Burchardt authored 9 years ago and Christoph Grüninger committed 9 years ago

(cherry picked from commit bc5578c4)

Ansgar Burchardt authored 9 years ago and Christoph Grüninger committed 9 years ago

(cherry picked from commit 7aa683f1)

Ansgar Burchardt authored 9 years ago and Christoph Grüninger committed 9 years ago

(cherry picked from commit bb04c50d)

Ansgar Burchardt authored 9 years ago and Christoph Grüninger committed 9 years ago

(cherry picked from commit d22ed390)

Ansgar Burchardt authored 9 years ago and Christoph Grüninger committed 9 years ago

(cherry picked from commit a5d7774e)

Before this commit communcation would be initiated even on empty
interfaces. While this does not lead to overwriting data or producing
segmentation faults, it does lead to accessing the first component of
empty vectors to get a pointer to pass to MPI functions. This produces
error output with valgrind and other memory debuggers. Therefore with this
commit we will first check whether the interface contains values and do
nothing if it doesn't. We also augmented the test to catch the case wher only
some processes have an empty interface.

This fixes FS#1614.

(cherry picked from commit f12adb99)

This fixes FS#1614.

The Metis test used the wrong one and I copied it for PTScotch... :/

This test has been added while the dune_enable_all_packages
feature was developed...

This branch adds the required infrastructure to automatically enable all
external packages and Dune-internal libraries for all targets inside a
given Dune modules. For this purpose, it adds a number of new CMake
macros:

- dune_enable_all_packages is the central macro that needs to be called
  in the main CMakeLists.txt of your project.

- dune_library_add_sources is an optional macro that you only need if
  your project also contains a library and you want your executables to
  automatically link against that library. Note that this support
  requires CMake 3.1. Most user modules don't create their own libraries
  and can thus ignore this macro.

- dune_register_package_flags has to be called in all configuration
  tests to register the outcome of the test so that
  dune_enable_all_packages can automatically add the required compiler
  and linker flags required to use the library that the configuration
  test has been written for.

The branch also adds the required calls to dune_register_package_flags
to all configuration tests in dune_common.

There is a similar branch in dune-grid that updates the configuration
tests in that module.

* feature/FS1557-add-all-flags-by-default-infrastructure:
  [CMake] dune_library_add_sources: Add some sanity checks
  [CMake] dune_enable_all_packages: Add sensible scoping to macro variables
  [CMake] Avoid duplicate version warnings in dune_library_add_sources
  [CMake] dune_enable_all_packages(): Add version check to library support
  [CMake] Clean up dune_enable_all_packages() and fix library handling
  [CMake][ParMETIS] Fix some typos in dune_register_package_flags() call
  [CMake] Export project revision as ProjectVersionRevision
  Fix c&p error in verbosity code
  Introduce an APPEND parameter on the dune_register_package_flags macro
  Issue a warning when the registry macros parameters cannot be parsed
  Introduce an optional VERBOSE argument on the dune_enable_all_packages macro
  Introduce a macro dune_register_package flags to be used by find modules
  [CMake] Move the enable_all_packages feature to a separate module
  Update the duneproject script to ask the user whether to use all flags
  Introduce a macro that adds all flags to all targets
  Update all find scripts split definitions from includes
  Split ALL_PKG_FLAGS into ALL_PKG_DEFS and ALL_PKG_INCS

This patch adds some sanity checks to dune_library_add_sources:

- Make sure that dune_enable_all_packages has been called

- Test whether the library has been declared in the MODULE_LIBRARIES
  argument of dune_enable_all_packages

In case of an error, the macro aborts the CMake run with a fatal error.

All variables defined in the macros stick around forever, so add a scope
matching the macro name to avoid name clashes.

The check for a correct cmake_minimum_version already happened in
dune_enable_all_packages, so let's avoid spamming the user...

The library support in dune_enable_all_packages (more specifically, the
ability to add source files to an existing library target with
dune_library_add_sources) relies on target_sources, which only exists in
CMake 3.1+.

To avoid confusing users, this patch emits a meaningful error for older
versions of CMake and generates a warning for more recent versions. This
warning can be disabled by defining
DUNE_ENABLE_ALL_PACKAGES_SILENCE_LIBRARY_WARNING.

...unless specificially set to false by the user.

Needed to properly support pthreads.
The copied file is modified because of
- lacking support of INTERFACE in older CMake versions
- difficulties finding default FindPackageHandleStandardArgs