When using NO_DEFAULT_PATH the lib and include subdirectories will
not be searched by default by find_path and pt-scotch will not be
found outside of the standard path. This commit adds them and now
locally installed versions may supersede the system ones.

(cherry picked from commit 0088d9d6)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

Without it linking will fail when using static libraries due
to missing symbols.

(cherry picked from commit 1ac52e06)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

Since commit 495f2fce USE_MPI was removed from dunecontrol and
the default configuration now defaults to use
parallelism. Unfortunately, there are downstream modules that try to
support multiple versions of DUNE. Sometimes these need to decide
whether to support parallelism before they know which version of DUNE
they are using. This is was not possible when providing
--enable-parallel as no variable gets set for DUNE>=2.4.

With this commit dunecontrol always sets
CMAKE_DISABLE_FIND_PACKAGE_MPI to an appropriate value. Thus if
dunecontrol is used then one can check in one's own module whether the
variable is set explicitly to false and conclude that one is using
>=2.4 and wants parallelism. Otherwise one can check USE_MPI to detect
which behaviour is needed for 2.3.

E.g. like this:
<code>
option (USE_MPI "Use Message Passing Interface for parallel computing" OFF)

if( NOT CMAKE_DISABLE_FIND_PACKAGE_MPI STREQUAL ""
    AND NOT CMAKE_DISABLE_FIND_PACKAGE_MPI)
  set(USE_MPI ON)
endif()

if (NOT USE_MPI)
      set (CMAKE_DISABLE_FIND_PACKAGE_MPI TRUE)
 set (CMAKE_DISABLE_FIND_PACKAGE_MPI TRUE)
endif (NOT USE_MPI)
</code>

Of course without dunecontrol and using the defaults one will still
configure DUNE as parallel, but one's own module as sequential.

(cherry picked from commit 14371eb3)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

Actually, having these files lying around does not hurt us.
In addition there are downstream modules that especially create
these for compatibility reasons with autotools. For these
reconfiguring a module using dunecontrol currently aborts with an error

Therefore this commit resorts to just issuing a warning and proceeding
with the compilation instead of aborting with an error.

(cherry picked from commit 21dbaefe)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

(cherry picked from commit 0031e54d)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

(cherry picked from commit 6121bbd9)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

... and don't take absolute value of comparison result.
Thanks to Max Kahnt for reporting this.

(cherry picked from commit 57a43efa)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

This lists all commits marked tagged as bugfix or release
that where explicitly not cherry-picked. Possible reasons for this:

* commits from a branch that was also merged to the release
* commits from a branch where the merge was cherry-picked
* bugfixes for code new to master
* commits that where picked but are not recognized as such

It's more CMake style.

(cherry picked from commit 635500eb)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

(cherry picked from commit a46de680)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

(cherry picked from commit b7809c2d)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

Some downstream modules like pdelab and dumux already abandoned the
current bahaviour of building tests on make test. The testing infrastructure
does throw them error messages during make test though. This commi introduces
the switch DUNE_DISABLE_TEST_MAGIC which may be set by downstream modules
to disable the magic. To see how to switch a downstream module, see:

http://conan2.iwr.uni-heidelberg.de/git/pdelab/dune-pdelab/commit/dc5ef4b39f5be5690457f0bbfe008b1f45d5fd98


(cherry picked from commit ebca3539)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

(cherry picked from commit 2b2d7f92)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

- add question concerning configure options
- add question concerning disabling options
- mention deletion of CMakeCache.txt

(cherry picked from commit b20014e9)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

Update CXXFLAG question.
More proof reading and line wrapping.

(cherry picked from commit 08c2294d)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

- Get rid of \\ at end of paragraphs
- Fix various misspellings
- add some convenience macros
- add myself as co-author
- break long lines which were modified anyway

(cherry picked from commit 8d2ee549)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

Commit 4878943f actuall did change
the default behavior, it effectifly disabled LaTex for some users.
To disable LaTeX pass -DCMAKE_DISABLE_FIND_PACKAGE_LATEX=TRUE

(cherry picked from commit 88bbf966)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

(cherry picked from commit f6ab9f0f)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

IteratorRanges are convenient for storing ranges of iterators into a
larger container, e.g. for the per-codim GeometryTypes in an
IndexSet. Unfortunately, you can't just create an array of
IteratorRanges right now because they can neither be copied, nor are
they default-constructible.

This patch fixes that problem and also adds a second typedef
const_iterator to make IteratorRange work in contexts where the
iterating code isn't using range-based for and assumes a const object.

(cherry picked from commit 2c9596f9)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

Setting a policy must be guarded as older CMake version do not
know about the policy.

CMake >= 2.8.12 can optionally use @rpath to embed dynamic linker paths
into shared libraries on OS X. This greatly improves reliability with
libraries in non-standard locations and should definitely be turned on
by default.

(cherry picked from commit 13fc4020)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

With the recent changes to bigunsignedint, the index cannot
be initialized with a negative value anymore. We change this
to 1 to overcome the problem.

This commit together with the recent bugfixes by Ansgar
fixes the AMG code on master.

(cherry picked from commit bf023947)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

(cherry picked from commit 6100b778)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

The shell script logic for switching dune_enable_all_packages() on or
off in duneproject was broken and always turned the feature on, ignoring
the user input.

Fixed by testing for the actual contents of the variable instead of its
length and by converting the contents to lowercase before.

(cherry picked from commit 346657b7)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

Since 0c697d8d messages of size zero
are no longer sent. This can reduce the number of requests we have to
wait for.

(cherry picked from commit f35437e9)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

The storage of bigunsignedint was changed to std::uint16_t in commit
541b3dfc. This implements the same
change for the MPITraits<bigunsignedint<k>>

Note that this assumes that
  MPITraits<std::uint16_t>
is defined. This is the case as long as uint16_t maps to one of the
standard integer types (unsigned char/short/int/long).

Thanks to Markus for pointing this out.

Reference: https://dune-project.org/flyspray/index.php?do=details&task_id=1657#comment6393


(cherry picked from commit 586375b4)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

The duncontrol / dune.module mechanism allowes to overload the run_* commands, which
are executed in order to setup/build/etc. a module. This patch fixes a bug in the cmake
parsing of the dune.module file. Somehow cmake tried to interpret the content of the
dune.module as cmake code. We now use a different strategy to parse the file and avoid
storing the content in a temporary variable.

>> please backport to 2.4

(cherry picked from commit bd20824b)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

script. This feature is disabled by default and can be enabled by
-DALLOW_CXXFLAGS_OVERWRITE=ON.

This branch fixes a number of problems related to
dune_enable_all_packages():

- The feature requires at least CMake 2.8.12, which is more recent than
  the baseline requirement of the core modules (2.8.12). We now check
  for that when executing the relevant functions and also remind the
  user to set the correct version in cmake_minimum_required().
- Updated the documentation to also state the version requirement.
- The duneproject script now also warns the user about the more
  stringent CMake version requirements when using the feature and sets
  the correct minimum required CMake version in the new module's main
  CMakeLists.txt file.
- There was a bug in duneproject that caused it to always enable
  dune_enable_all_packages(), ignoring the choice made by the user. That
  bug is fixed in this branch.
- Some minor fixes to duneproject while I was at it.

This fixes FS1678.

* feature/FS1678:
  [dunecontrol] Output choice of external package handling and required CMake version
  [duneproject] Allow specifying ENABLE_ALL as 5th command line argument
  [duneproject] Update CMake minimum version if ENABLE_ALL is true
  [duneproject][Bugfix] Make sure dune_enable_all_packages() can actually be disabled
  [CMake] Improve documentation in DuneEnableAllPackages.cmake
  [CMake][Doc] Add required CMake version to dune_enable_all_packages()
  [CMake] Require CMake 2.8.12 for dune_enable_all_packages()
  [CMake] Fix typo in warning message.
  Add a warning that some functions are 2.8.12

(cherry picked from commit 90411efd)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

Viz., the question on whether all packages should be enabled by default.

This fixes FS 1647.

(cherry picked from commit 20ac0ea1)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

(cherry picked from commit 58221538)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

(cherry picked from commit 648dff2b)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

(cherry picked from commit ae8fd0da)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

This bug could only be found outside Germany :D

(cherry picked from commit ecdb7f7b)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

This document gathers some beginners question about the CMake
build system. It is built during make doc and made available
on the website through the doc installation.

(cherry picked from commit c2e198a9)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>