(cherry picked from commit f6ab9f0f)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

Setting a policy must be guarded as older CMake version do not
know about the policy.

CMake >= 2.8.12 can optionally use @rpath to embed dynamic linker paths
into shared libraries on OS X. This greatly improves reliability with
libraries in non-standard locations and should definitely be turned on
by default.

(cherry picked from commit 13fc4020)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

The duncontrol / dune.module mechanism allowes to overload the run_* commands, which
are executed in order to setup/build/etc. a module. This patch fixes a bug in the cmake
parsing of the dune.module file. Somehow cmake tried to interpret the content of the
dune.module as cmake code. We now use a different strategy to parse the file and avoid
storing the content in a temporary variable.

>> please backport to 2.4

(cherry picked from commit bd20824b)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

script. This feature is disabled by default and can be enabled by
-DALLOW_CXXFLAGS_OVERWRITE=ON.

This branch fixes a number of problems related to
dune_enable_all_packages():

- The feature requires at least CMake 2.8.12, which is more recent than
  the baseline requirement of the core modules (2.8.12). We now check
  for that when executing the relevant functions and also remind the
  user to set the correct version in cmake_minimum_required().
- Updated the documentation to also state the version requirement.
- The duneproject script now also warns the user about the more
  stringent CMake version requirements when using the feature and sets
  the correct minimum required CMake version in the new module's main
  CMakeLists.txt file.
- There was a bug in duneproject that caused it to always enable
  dune_enable_all_packages(), ignoring the choice made by the user. That
  bug is fixed in this branch.
- Some minor fixes to duneproject while I was at it.

This fixes FS1678.

* feature/FS1678:
  [dunecontrol] Output choice of external package handling and required CMake version
  [duneproject] Allow specifying ENABLE_ALL as 5th command line argument
  [duneproject] Update CMake minimum version if ENABLE_ALL is true
  [duneproject][Bugfix] Make sure dune_enable_all_packages() can actually be disabled
  [CMake] Improve documentation in DuneEnableAllPackages.cmake
  [CMake][Doc] Add required CMake version to dune_enable_all_packages()
  [CMake] Require CMake 2.8.12 for dune_enable_all_packages()
  [CMake] Fix typo in warning message.
  Add a warning that some functions are 2.8.12

(cherry picked from commit 90411efd)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

For discussion check FS1648.

Disabling a cmake module through CMAKE_DISABLE_FIND_PACKAGE_...
was only partially working:
- Any module suggesting the disabled module would not search for it
- dunecontrol did not have this knowledge and built the disabled module nevertheless

This commit fixes the latter.

(cherry picked from commit 8b04df71)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

BOOST_FOUND seems to be no longer known, use
HAVE_DUNE_BOOST instead.

(cherry picked from commit dfeeea79)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

Affected are older CMake versions 2.8.6 to 2.8.9 maybe even,
newer versions.

(cherry picked from commit 2d38fedf)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

dune_library_add_sources() verifies the library name against the
contents of DUNE_ENABLE_ALL_PACKAGES_MODULE_LIBRARIES. I accidentally
broke this by converting dune_enable_all_packages (which defines the
variable) from a macro to a function, which removed the variable from
global scope.

This patch fixes the problem by explicitly exporting the variable to the
parent scope, making it available to dune_library_add_sources() again.

(cherry picked from commit 289d3eb6)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

on Ubuntu.

(cherry picked from commit 71e08e51)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

Passing multiple files to dune_symlink_to_source_files() was broken.
While at it, I switched the given macros to be functions and have
named arguments. Using positional arguments will result in a warning.

(cherry picked from commit 797fbfa1)
Signed-off-by: Carsten Gräser <graeser@dune-project.org>

We have to call add_definitions() in a loop because add_definitions() is
kind of broken: even though it is supposed to be *the* function for
adding compile definitions, it does not prepend "-D" (as opposed to
target_compile_definitions(), which does). Well, whatever...

(cherry picked from commit bd578fd8)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

Thanks for spotting that, Dominic!

(cherry picked from commit c849d756)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

This branch resolves somes smaller problems with the
dune_enable_all_packages() feature and importantly provides support for
modules with libraries and CMake < 3.1.

* feature/FS1654-improve-dune-enable-all-packages:
  [Release][CMake] Add support for compile options in DuneEnableAllPackages
  [Release][CMake][Bugfix] Use correct test in if() command
  [Release][CMake] Add dune_target_enable_all_packages()
  [Release][CMake][Bugfix] Remove stray unset() command
  [Release][CMake] Convert macros to functions in DuneEnableAllPackages
  [Release][CMake] Improve documentation in DuneEnableAllPackages.cmake

(cherry picked from commit 7cc5bc4b)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

We do not really support this combination of C++11 features, and the
only time it should occur is when the user has a recent Intel Compiler
and an outdated GCC (which the Intel Compiler uses for the C++ standard
library). In that case, we emit a helpful error message at configuration
time.

(cherry picked from commit c3e637ab)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

The test for __cxa_demangle(), which is used by Dune::className() to
demangle type names, doesn't work on my clang 3.6. Apparently, clang
requires the user to include <typeinfo> before <cxxabi.h>. While
classname.hh already does this, the build system tests don't, causing the
feature to get disabled on clang.

Fixed by adding the include to the build system tests.

(cherry picked from commit 70f52c0d)
Signed-off-by: Steffen Müthing <muething@dune-project.org>

DuneEnableAllPackages.cmake, FindThreadsCMake31.cmake and
CheckForPthreads.c were missing in the Dune-common installation.

Ansgar Burchardt authored 9 years ago and Christoph Grüninger committed 9 years ago

(cherry picked from commit bb04c50d)

Ansgar Burchardt authored 9 years ago and Christoph Grüninger committed 9 years ago

(cherry picked from commit d22ed390)

Ansgar Burchardt authored 9 years ago and Christoph Grüninger committed 9 years ago

(cherry picked from commit a5d7774e)

This fixes FS#1614.

(cherry picked from commit f12adb99)

This fixes FS#1614.

The Metis test used the wrong one and I copied it for PTScotch... :/

This test has been added while the dune_enable_all_packages
feature was developed...

This patch adds some sanity checks to dune_library_add_sources:

- Make sure that dune_enable_all_packages has been called

- Test whether the library has been declared in the MODULE_LIBRARIES
  argument of dune_enable_all_packages

In case of an error, the macro aborts the CMake run with a fatal error.

All variables defined in the macros stick around forever, so add a scope
matching the macro name to avoid name clashes.

The check for a correct cmake_minimum_version already happened in
dune_enable_all_packages, so let's avoid spamming the user...

The library support in dune_enable_all_packages (more specifically, the
ability to add source files to an existing library target with
dune_library_add_sources) relies on target_sources, which only exists in
CMake 3.1+.

To avoid confusing users, this patch emits a meaningful error for older
versions of CMake and generates a warning for more recent versions. This
warning can be disabled by defining
DUNE_ENABLE_ALL_PACKAGES_SILENCE_LIBRARY_WARNING.

...unless specificially set to false by the user.