This makes the code more robust and (a bit) more robust.  Additionally,
it repairs the recent breakage that I introduced by modifying promotiontraits.hh.

Otherwise FieldVector is not a literal type and
calling its size() method is not a const-expression
although size() itself is declared as constexpr.

The previous implementation consisted of a list of promotion rules for
various types.  The new implementation is much shorter and more general:
it will also work for types not on the old list.  The promoted type is
now defined as the result type of the addition of the two input types.
There is no special reason to use addition here, but it does reproduce
the precise behavior of the old implementation.

Document an incompatibility issue of index_sequence
and add a reminder to fix this as soon as we allow
template aliases.
This can only be fixed

This does not apply cleanly to the release.

by testing whether we work on a end iterator. In this case the distance
function will fail. Found that out by gcc's stdlib with debugging turned on.

... and don't take absolute value of comparison result.
Thanks to Max Kahnt for reporting this.

Otherwise it won't appear in the doxygen documentation

Add missing files, remove ancient buildsystem stuff and stuff where it is
unclear where it comes from.

[test][typetraits][warnings] Split the test for deprecated functionality in typetraits.hh into its own testcase.  That way I can simply disable deprecation warnings there.

There was a mechanism with apparently similar goal involving the define
DISABLE_DEPRECATED_METHOD_CHECKS.  However, I could not figure out how that
was intended to work, the only occurances of DISABLE_DEPRECATED_METHOD_CHECKS
were in typetraitstest.hh.  Probably you were supposed to set that define by
hand in your CPPFLAGS, which I consider unacceptable.

The section is empty since the code was split into the dune-geometry
module.

Since fda5a9e0 AlignmentOf always uses
std::alignment_of and the fallback implementation is no longer used.

It's more CMake style.

Since de430584 HAVE_DUNE_HASH is
always defined.

Nicolas Schwenck authored 9 years ago and Christoph Grüninger committed 9 years ago

floating comparisons

Point to proposal for C++17 make_array(), and point out the differences of our
implementation.

That inhibits RVO and actually makes the code slower.  And even if the
compiler decides against RVO, the standard requires that he moves from the
object, if possible.  See Scott Meyers "Effective Modern C++", second half of
Item 25.

Thanks Markus Blatt for noticing.

Marco Agnese authored 9 years ago and Jö Fahlke committed 9 years ago

Use std::array instead of Dune::array.
[make_array] use variadic template instead of different specialization

IteratorRanges are convenient for storing ranges of iterators into a
larger container, e.g. for the per-codim GeometryTypes in an
IndexSet. Unfortunately, you can't just create an array of
IteratorRanges right now because they can neither be copied, nor are
they default-constructible.

This patch fixes that problem and also adds a second typedef
const_iterator to make IteratorRange work in contexts where the
iterating code isn't using range-based for and assumes a const object.

With the recent changes to bigunsignedint, the index cannot
be initialized with a negative value anymore. We change this
to 1 to overcome the problem.

This commit together with the recent bugfixes by Ansgar
fixes the AMG code on master.

Since 0c697d8d messages of size zero
are no longer sent. This can reduce the number of requests we have to
wait for.

The storage of bigunsignedint was changed to std::uint16_t in commit
541b3dfc. This implements the same
change for the MPITraits<bigunsignedint<k>>

Note that this assumes that
  MPITraits<std::uint16_t>
is defined. This is the case as long as uint16_t maps to one of the
standard integer types (unsigned char/short/int/long).

Thanks to Markus for pointing this out.

Reference: https://dune-project.org/flyspray/index.php?do=details&task_id=1657#comment6393

This bug could only be found outside Germany :D

the first problem was that I accidentially enabled the ScalarOrderingTest, but this forced me
to investigate further and I found out how this works, or not works.

We have to add the comparison operators to FieldVector, as the cast operator does not always
match, e.g. in the case of GMPField.