Before this commit it matched e.g. "test1" and failed finding the directory "test".

Previously, a variable (found) was only initialized in one branch
of an if statement but used later on in any case. This patch makes
sure that is initialized in both branches.

This fixes FS#1352.
Thanks to Bernd Flemisch for the hint.

[BuildSystem][autotools] Add FinalizeHeadercheck.cmake to installation file list of cmake/scripts instead of incorrect cmake/modules.

Dominic Kempf authored 11 years ago and Markus Blatt committed 11 years ago

[BuildSystem][CMake] Add FinalizeHeadercheck.cmake to installation file list of cmake/scripts instead of incorrect cmake/modules.

Previously the CMAKE variable was not set if no options file was used. This
fixes this.

Dominic Kempf authored 11 years ago and Markus Blatt committed 11 years ago

Exclusion from the headercheck can be achieved in a CMakeLists.txt
file via the following macros:

exclude_from_headercheck(list...)
exclude_dir_from_headercheck()
exclude_all_but_from_headercheck(list...)

When not excluded, all headers matching dune/*.hh or src/*.hh
will be checked.

Unlike with autotools, make headercheck can only be called on the
toplevel module directory and then run on all module headers. In
contrast to autotools, CMake will cache the results and rerun only
checks on changed headers.

Steffen Müthing authored 11 years ago and Christoph Grüninger committed 11 years ago

The current algorithm for hash combining behaves very poorly when hashing
multiple short streams of small integers like (0,1,1,0,x) that only differ
by a single large number x. These objects appear frequently in PDELab's ordering
framework, and the resulting bad hash distribution really hurts the performance
of the unordered containers in PDELab.

This patch switches to an algorithm that is inspired by CityHash (see the source
code comment) and has proven to be much more robust in testing.

With this patch it is possible to request CMake for building
by setting USE_CMAKE=yes in an option file.

In one of the latest patches I introduced a bug which caused
the --builddir option of dunecontrol to not make any effect.
This patch fixes this.

There is no obvious reason to quote one variable and not the other.
If more CMP0019 warnings are found, they have to be fixed in the same
way.
This was only an issue with CMake 2.8.11 or newer.

Because C++11 implements this differently, and we now have an
stl-compliant implementation to switch to.

I would deprecate isPointer and isReference too, but I can't find
a way to do it.

These are replacements for TypeTraits::isPointer, TypeTraits::isReference,
TypeTraits::PointeeType.  They reimplement what is available in the
C++11 standard library, and are expected to supersede the TypeTraits
class eventually.

Note: this patch does not pull in the corresponding stl implementation.

That's easier to maintain.

This fixes the parsing of git config options.
Be aware that you can use shell code in these options!
Thanks to Steffen Müthig for this fix!