fix FS#621

* implement rangecheck for finite stack (disabled when compiling with NDEBUG)
* fix lru with _GLIBCXX_DEBUG

[[Imported from SVN: r5753]]

dune/common/finitestack.hh

@@ -45,18 +45,33 @@ namespace Dune {
     //! Puts a new object onto the stack
     void push (const T& t)
     {
+#ifndef NDEBUG
+      if (full())
+        DUNE_THROW(Dune::RangeError,
+                   "trying to call push on a full FiniteStack");
+#endif
       s[f++] = t;
     }
 
     //! Removes and returns the uppermost object from the stack
     T pop ()
     {
+#ifndef NDEBUG
+      if (empty())
+        DUNE_THROW(Dune::RangeError,
+                   "trying to call top on an empty FiniteStack");
+#endif
       return s[--f];
     }
 
     //! Returns the uppermost object on the stack
     T top () const
     {
+#ifndef NDEBUG
+      if (empty())
+        DUNE_THROW(Dune::RangeError,
+                   "trying to call pop on an empty FiniteStack");
+#endif
       return s[f-1];
     }
 

dune/common/lru.hh

@@ -158,7 +158,7 @@ namespace Dune {
       /* insert item as mru */
       iterator it = _data.insert(_data.begin(), x);
       /* store index */
-      _index[key] = it;
+      _index.insert(std::make_pair(key,it));
 
       return it->second;
     }

dune/common/test/test-stack.cc

@@ -47,6 +47,7 @@ int main () {
     stack1.pop();
 
     // exception has to happen
+    // make sure you compile this test without NDEBUG
     std::cerr << "Expected exception Dune::RangeError, but nothing caught\n";
     return 1;
   } catch (Dune::RangeError &e) {