Skip to content
Snippets Groups Projects
  1. Mar 18, 2020
  2. Mar 17, 2020
  3. Mar 13, 2020
  4. Mar 12, 2020
  5. Mar 09, 2020
  6. Mar 03, 2020
  7. Feb 28, 2020
    • Lukas Renelt's avatar
      53ea620e
    • Christian Engwer's avatar
      [!670] Loopsimd alignment · 3c5922d7
      Christian Engwer authored
      Merge branch 'loopsimd_alignment' into 'master'
      
      ref:core/dune-common\> This MR adds a additional template parameter to
      LoopSIMD to specify the alignment.
      
      The default alignment is the alignment of the underlying type.
      
      I'm not sure how to determine the proper alignment for some return types or
      RebindType. To mitigate that problem I define conversion constructors and
      assignment operators from LoopSIMD types with different alignment.
      
      This MR depends on [!669].
      
      Feel free to push at the source branch!
      
      See merge request [core/dune-common!670]
      
        [!669]: gitlab.dune-project.org/NoneNone/merge_requests/669
        [core/dune-common!670]: gitlab.dune-project.org/core/dune-common/merge_requests/670
      3c5922d7
    • Christian Engwer's avatar
      [!669] LoopSIMD for vector types · 32c2fdd3
      Christian Engwer authored
      Merge branch 'loopsimd_for_vector_types' into 'master'
      
      ref:core/dune-common\> This MR adapts LoopSIMD to take another vectorized type
      as template argument. If Tis a vectorized type, then LoopSIMD<T,k> has
      lanes<T>()*k lanes and the same scalar as T (Scalar<LoopSIMD<T,k>> ==
      Scalar<T>).
      
      This is useful with dune-vectorclass, to create arbitrary large vector types
      with explicit SIMD support, for example.
      
      Feel free to push any changes to the source branch!
      
      See merge request [core/dune-common!669]
      
        [core/dune-common!669]: gitlab.dune-project.org/core/dune-common/merge_requests/669
      32c2fdd3
    • Lukas Renelt's avatar
      d4d36dc5
  8. Feb 27, 2020
  9. Feb 26, 2020
  10. Feb 17, 2020
    • Jö Fahlke's avatar
      [!775] SIMD test: fix implicit this capture warnings · 207d6bb5
      Jö Fahlke authored
      Merge branch 'fix-implicit-this-capture' into 'master'
      
      ref:core/dune-common C++20 deprecates implicit capture of this using [=], and
      gcc9 warns about that. Unfortunately, in C++ before 20 listing this together
      with a capture-default of = is illegal, and GCC 8 emits a warning about that
      that apparently can't be silenced. So the only option if we want to appease
      both pre- and post-C++20 is to list each entity to be captures explicitly.
      Luckily, that is not too hard in this case.
      
      See [https://gitlab.dune-project.org/core/dune-common/-/jobs/139584\#L486]
      (debian:11 gcc-9-20):
      
          [ 40%] Building CXX object dune/common/CMakeFiles/dunecommon.dir/simd/test.cc.o
          In file included from /builds/core/dune-common/dune/common/simd/test.cc:6:
          /builds/core/dune-common/dune/common/simd/test.hh: In lambda function:
          /builds/core/dune-common/dune/common/simd/test.hh:334:36: warning: implicit capture of 'this' via '[=]' is deprecated in C++20 [-Wdeprecated]
            334 |         Hybrid::forEach(Rebinds{}, [=](auto target) {
                |                                    ^
          /builds/core/dune-common/dune/common/simd/test.hh:334:36: note: add explicit 'this' or '*this' capture
      
      WIP:
      
      -   [x] Check these warnings are really gone in the CI
      
      See merge request [core/dune-common!775]
      
        [https://gitlab.dune-project.org/core/dune-common/-/jobs/139584\#L486]: https://gitlab.dune-project.org/core/dune-common/-/jobs/139584#L486
        [core/dune-common!775]: gitlab.dune-project.org/core/dune-common/merge_requests/775
      207d6bb5
    • Jö Fahlke's avatar
      SIMD test: fix implicit this capture warnings · 5a14116e
      Jö Fahlke authored
      C++20 deprecates implicit capture of `this` using `[=]`, and gcc9 warns about
      that.  Unfortunately, in C++ before 20 listing `this` together with a
      capture-default of `=` is illegal, and GCC 8 emits a warning about that that
      apparently can't be silenced.  So the only option if we want to appease both
      pre- and post-C++20 is to list each entity to be captures explicitly.
      Luckily, that is not too hard in this case.
      
      See https://gitlab.dune-project.org/core/dune-common/-/jobs/139584#L486
      (debian:11 gcc-9-20):
      ```
      [ 40%] Building CXX object dune/common/CMakeFiles/dunecommon.dir/simd/test.cc.o
      In file included from /builds/core/dune-common/dune/common/simd/test.cc:6:
      /builds/core/dune-common/dune/common/simd/test.hh: In lambda function:
      /builds/core/dune-common/dune/common/simd/test.hh:334:36: warning: implicit capture of 'this' via '[=]' is deprecated in C++20 [-Wdeprecated]
        334 |         Hybrid::forEach(Rebinds{}, [=](auto target) {
            |                                    ^
      /builds/core/dune-common/dune/common/simd/test.hh:334:36: note: add explicit 'this' or '*this' capture
      ```
      5a14116e
    • Jö Fahlke's avatar
      [!773] Fix warnings, add comments in fvectorconversion1d.cc test · 504bd2d4
      Jö Fahlke authored
      Merge branch 'fix-warning-add-comments' into 'master'
      
      ref:core/dune-common This is a regression test, the threw up undefined
      variable warnings. unsure about the correct fix, I tried to understand the
      test. In addition to fixing the warnings, I left some comments too, in the
      hope future readers will have a little easier time understanding what it is
      supposed to do.
      
      The warnings showed up in
      [https://gitlab.dune-project.org/core/dune-common/-/jobs/139437\#L665]
      (debian:10 clang-7-libcpp-17):
      
          [ 60%] Building CXX object dune/common/test/CMakeFiles/fvectorconversion1d.dir/fvectorconversion1d.cc.o
          /builds/core/dune-common/dune/common/test/fvectorconversion1d.cc:86:16: warning: unused variable 'mfv' [-Wunused-variable]
                MiddleFV mfv;
                         ^
          /builds/core/dune-common/dune/common/test/fvectorconversion1d.cc:107:16: warning: unused variable 'mfv' [-Wunused-variable]
                MiddleFV mfv;
                         ^
          2 warnings generated.
      
      See also: [!735], [!562]
      
      See merge request [core/dune-common!773]
      
        [https://gitlab.dune-project.org/core/dune-common/-/jobs/139437\#L665]: https://gitlab.dune-project.org/core/dune-common/-/jobs/139437#L665
        [!735]: gitlab.dune-project.org/NoneNone/merge_requests/735
        [!562]: gitlab.dune-project.org/NoneNone/merge_requests/562
        [core/dune-common!773]: gitlab.dune-project.org/core/dune-common/merge_requests/773
      504bd2d4
    • Jö Fahlke's avatar
      Fix warnings, add comments in fvectorconversion1d.cc test · 1802c531
      Jö Fahlke authored
      This is a regression test, the threw up undefined variable warnings.  unsure
      about the correct fix, I tried to understand the test.  In addition to fixing
      the warnings, I left some comments too, in the hope future readers will have a
      little easier time understanding what it is supposed to do.
      
      The warnings showed up in
      https://gitlab.dune-project.org/core/dune-common/-/jobs/139437#L665 (debian:10
      clang-7-libcpp-17):
      ```
      [ 60%] Building CXX object dune/common/test/CMakeFiles/fvectorconversion1d.dir/fvectorconversion1d.cc.o
      /builds/core/dune-common/dune/common/test/fvectorconversion1d.cc:86:16: warning: unused variable 'mfv' [-Wunused-variable]
            MiddleFV mfv;
                     ^
      /builds/core/dune-common/dune/common/test/fvectorconversion1d.cc:107:16: warning: unused variable 'mfv' [-Wunused-variable]
            MiddleFV mfv;
                     ^
      2 warnings generated.
      ```
      
      See also: !735, !562
      1802c531
  11. Feb 16, 2020
  12. Feb 15, 2020
    • Jö Fahlke's avatar
      [!769] function.hh useful deprecation · 383d9523
      Jö Fahlke authored
      Merge branch 'function.hh-useful-deprecation' into 'master'
      
      ref:core/dune-common Make the deprecation of function.hh more useful
      
      -   Move it outside of inclusion guard so it triggers on every include (\#186)
      -   #undef the disarming-define once it has suppressed a warning so the
          warning will fire again in the next include (\#186)
      -   Mention the dune version in the warning so we know when we can finally
          remove it
      -   deprecate also the individual classes and function in function.hh so it is
          easier to know what exactly to fix
      
      See merge request [core/dune-common!769]
      
        [core/dune-common!769]: gitlab.dune-project.org/core/dune-common/merge_requests/769
      383d9523
    • Jö Fahlke's avatar
      function.hh: deprecate contents · 8d8f9d20
      Jö Fahlke authored
      Deprecate the classes and functions in function.hh too, so it is easier to
      tell what one needs to do to update a file when it throws warnings
      8d8f9d20
    • Jö Fahlke's avatar
      function.hh: Version deprecation warning · 2b86b28c
      Jö Fahlke authored
      Make it possible to tell at a glance when the deprecation was put into effect,
      so we can know when we can remove the stuff.
      2b86b28c
Loading