Fix comparison tests

Before, the md comparison version was not obtaining the grid functions from the latest state and led to much higher errors and a different result with respect to sd executable

dune/copasi/common/pdelab_expression_adapter.hh

@@ -239,4 +239,4 @@ auto get_muparser_expressions(
 
 } // namespace Dune::Copasi
 
-#endif // DUNE_COPASI_GRID_FUNCTION_EXPRESSION_ADAPTER_HH
\ No newline at end of file
+#endif // DUNE_COPASI_GRID_FUNCTION_EXPRESSION_ADAPTER_HH

dune/copasi/model/diffusion_reaction.hh

@@ -28,7 +28,6 @@
 #include <dune/pdelab/gridfunctionspace/vtk.hh>
 #include <dune/pdelab/gridoperator/gridoperator.hh>
 #include <dune/pdelab/gridoperator/onestep.hh>
-#include <dune/pdelab/newton/newton.hh>
 
 #include <dune/grid/io/file/vtk/vtksequencewriter.hh>
 #include <dune/grid/io/file/vtk/vtkwriter.hh>

test/dune_copasi_md_compare.cc

@@ -114,8 +114,7 @@ main(int argc, char** argv)
       auto sub_grid_view = md_grid_ptr->subDomain(domain).leafGridView();
 
       gf_expressions.emplace_back(Dune::Copasi::get_muparser_expressions(
-        model_config.sub(compartments[domain] + ".compare.expression"),
-        sub_grid_view));
+        model_config.sub(compartment + ".compare.expression"), sub_grid_view));
     }
 
     // get compare paramter tree for a specific variable
@@ -162,7 +161,7 @@ main(int argc, char** argv)
 
     auto compare_m = [=](const auto& model, const auto& state) {
       // 2. get resulting grid functions
-      auto gf_results = model.get_grid_functions();
+      auto gf_results = model.get_grid_functions(state);
       assert(gf_results.size() == gf_expressions.size());
 
       // 3. set expression grid functions to current time

test/test_exp.mini

@@ -43,7 +43,7 @@ u = 0.
 [model.domain.compare.expression]
 u = exp({_grow_rate}*t)
 [model.domain.compare.l2_error]
-u = 1e-3
+u = 2.4e-4
 
 ############################ Logging settings #################################
 # levels = off, critical, error, waring, notice, info, detail, debug, trace, all

test/test_gauss.mini

@@ -45,7 +45,7 @@ u = {_diffusion}
 [model.domain.compare.expression]
 u = {_gauss_eq}
 [model.domain.compare.l2_error]
-u = 0.255 , 0.085 | expand geometry_type
+u = 0.255 , 0.076 | expand geometry_type
 
 ############################ Logging settings #################################
 # levels = off, critical, error, waring, notice, info, detail, debug, trace, all