Resolve "Fix quadratic time complexity for increasing of numer of species with no reactions"
Merged
requested to merge 53-fix-quadratic-time-complexity-for-increasing-of-numer-of-species-with-no-reactions into master
What does this MR do?
This MR basically moves the read of the reactions and its jacobians within the components loop. This reduced the complexity from quadratic to linear in cases where no interactions between species are needed. The source of this performance issue was explored using the llvm-xray-tools.
Can this MR be accepted?
-
I've read contribution guide
-
Implemented [ ] Added/Updated tests[ ] Added/Updated documentation-
Pipelines passing -
Delete branch option set -
Fast-forwaded git merge is possible -
Added entry to CHANGELOG.md
Related issues
Closes #53 (closed)
Edited by Santiago Ospina De Los Ríos
Merge request reports
Activity
changed milestone to %M2.3 - Error control and performance
added Kind:Bug Kind:Performance Language:C++ labels
added 1 commit
- 101c363d - Remove redundant loops. Increase performance
added 6 commits
-
101c363d...9f2cb030 - 5 commits from branch
master
- 54a77284 - Remove redundant loops. Increase performance
-
101c363d...9f2cb030 - 5 commits from branch
assigned to @santiago.ospina
added 250 commits
-
54a77284...88464fa3 - 248 commits from branch
master
- 860cf0aa - Remove redundant loops. Increase performance
- 00c51b59 - Add entry to changelog
-
54a77284...88464fa3 - 248 commits from branch
marked the checklist item Added entry to
CHANGELOG.md
as completedenabled an automatic merge when the pipeline for 6d67480b succeeds
marked the checklist item Fast-forwaded git merge is possible as completed
mentioned in issue #23 (closed)
Please register or sign in to reply