Skip to content
Snippets Groups Projects
Commit 3c6d0dee authored by Samuel Burbulla's avatar Samuel Burbulla Committed by Andreas Dedner
Browse files

Add note to CHANGELOG.md

Reset LD_LIBARY_PATH when call deactivate.

Fix dynamic_lookup.
parent 8c79cfd0
Branches
Tags
1 merge request!900Feature/scikit build
......@@ -15,6 +15,12 @@
Furthermore, flags for either shared library or position independent code
needs to be used.
- Support for distributing DUNE modules as python packages has been added.
Package meta data is parsed in `packagemetadata.py` from the dune.module file.
A script `/bin/dunepackaging.py` was added to generate package files
(`setup.py`, `pyproject.toml`) that can also be used to upload packages to
the Python Package Index.
- Eigenvectors of symmetric 2x2 `FieldMatrix`es are now computed correctly
even when they have zero eigenvalues.
......
envpath=`dirname "${BASH_SOURCE[0]}"`
source $envpath/activate
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$VIRTUAL_ENV/lib
_OLD_LD_LIBRARY_PATH="$LD_LIBRARY_PATH"
LD_LIBRARY_PATH="$VIRTUAL_ENV/lib:$LD_LIBRARY_PATH"
export LD_LIBRARY_PATH
save_function() {
local ORIG_FUNC=$(declare -f $1)
local NEWNAME_FUNC="$2${ORIG_FUNC#$1}"
eval "$NEWNAME_FUNC"
}
save_function deactivate old_deactivate
deactivate () {
if [ -n "${_OLD_LD_LIBRARY_PATH:-}" ] ; then
LD_LIBRARY_PATH="${_OLD_LD_LIBRARY_PATH:-}"
export LD_LIBRARY_PATH
unset _OLD_LD_LIBRARY_PATH
fi
old_deactivate
unset -f old_deactivate
}
......@@ -79,7 +79,7 @@ function(dune_add_pybind11_module)
# https://pybind11.readthedocs.io/en/stable/compiling.html#building-manually
if (APPLE)
set_target_properties(${PYBIND11_MODULE_NAME} PROPERTIES SUFFIX ".so")
target_link_options(${PYBIND11_MODULE_NAME} PRIVATE "-undefined dynamic_lookup")
target_link_options(${PYBIND11_MODULE_NAME} PRIVATE -undefined dynamic_lookup)
endif()
target_compile_definitions(${PYBIND11_MODULE_NAME} PRIVATE ${PYBIND11_MODULE_COMPILE_DEFINITIONS})
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment