I am actually not sure. I currently cannot oversee the consequences.
I am also a bit surprised. Your changes to the debugaligntest
are actually included in 2.10. The jobs are identical. What has changed are the toolc...
I think you want to be able to move data into the future. However, you provide the data it's forwarded to the future. See https://gitlab.dune-proje...
@santiago.ospina @simon.praetorius If you are both sure this will not be a problem for any downstream users, I can change it and hard-code the new ...
I am wondering, why is this a forwarding reference at all?
-
c280a67c · [cmake] Set suggested module deps policy to new
- ... and 2 more commits. Compare cee72d2b...c280a67c
I think this approach directly will not work (DUNE_ENABLE_PYTHONBINDINGS
could be anything even an empty string or something including _NOT_FOUND
) ...
I think dune_buildsystem_minimum_required
would be great.
For instance in dune-grid, if we directly hard-code the new policy, dune-uggrid would disappear from the dependency list. Essentially in all module...
Yes, maybe we don't need a policy for this one....
I prefer named arguments. Makes it easier to extend the interface in the future if necessary.
-
cee72d2b · [cmake] Make module dependency findable in build setting
- ... and 9 more commits. Compare eca8619a...cee72d2b
-
eca8619a · wefew
- ... and 4 more commits. Compare ddbf6b34...eca8619a
-
6c107807 · [cmake] Only print TBB found msg when first found
- ... and 71 more commits. Compare 38f5393c...6c107807
option(BUILD_SHARED_LIBS "Build shared libraries" ${DUNE_ENABLE_PYTHONBINDINGS})
-
af260cf5 · Merge branch 'fix/cmake-feature-summary-verbosity' into 'master'
- ... and 1 more commit. Compare 7cded48b...af260cf5
-
9bc06531 · [communication][fix] Fix data type of isend