Skip to content
Snippets Groups Projects
Simon Praetorius's avatar
commented on merge request !1531 "[cmake] Only require modules in 'Depends:' with new policy" at Core Modules / dune-common

I am actually not sure. I currently cannot oversee the consequences.

Simon Praetorius's avatar
commented on merge request !1529 "Run the core and system pipelines with release branches" at Core Modules / dune-common

I am also a bit surprised. Your changes to the debugaligntest are actually included in 2.10. The jobs are identical. What has changed are the toolc...

Timo Koch's avatar
opened issue #407 "How to use MPI_Waitall" at Core Modules / dune-common
Timo Koch's avatar
commented on merge request !1534 "[communication] Fix const communication methods" at Core Modules / dune-common

I think you want to be able to move data into the future. However, you provide the data it's forwarded to the future. See https://gitlab.dune-proje...

Timo Koch's avatar
commented on merge request !1531 "[cmake] Only require modules in 'Depends:' with new policy" at Core Modules / dune-common

@santiago.ospina @simon.praetorius If you are both sure this will not be a problem for any downstream users, I can change it and hard-code the new ...

Simon Praetorius's avatar
commented on merge request !1534 "[communication] Fix const communication methods" at Core Modules / dune-common

I am wondering, why is this a forwarding reference at all?

Timo Koch's avatar
Simon Praetorius's avatar
commented on merge request !1422 "Build dynamic library by default" at Core Modules / dune-common

I think this approach directly will not work (DUNE_ENABLE_PYTHONBINDINGS could be anything even an empty string or something including _NOT_FOUND) ...

Timo Koch's avatar
commented on merge request !1531 "[cmake] Only require modules in 'Depends:' with new policy" at Core Modules / dune-common

I think dune_buildsystem_minimum_required would be great.

Timo Koch's avatar
commented on merge request !1531 "[cmake] Only require modules in 'Depends:' with new policy" at Core Modules / dune-common

For instance in dune-grid, if we directly hard-code the new policy, dune-uggrid would disappear from the dependency list. Essentially in all module...

Simon Praetorius's avatar
commented on merge request !1531 "[cmake] Only require modules in 'Depends:' with new policy" at Core Modules / dune-common

Yes, maybe we don't need a policy for this one....

Timo Koch's avatar
commented on merge request !1531 "[cmake] Only require modules in 'Depends:' with new policy" at Core Modules / dune-common

I prefer named arguments. Makes it easier to extend the interface in the future if necessary.

Timo Koch's avatar
Timo Koch's avatar
Timo Koch's avatar
commented on merge request !1422 "Build dynamic library by default" at Core Modules / dune-common
option(BUILD_SHARED_LIBS "Build shared libraries" ${DUNE_ENABLE_PYTHONBINDINGS})
Timo Koch's avatar
deleted branch fix/cmake-feature-summary-verbosity at Core Modules / dune-common
Timo Koch's avatar
pushed to branch master at Core Modules / dune-common
Timo Koch's avatar
accepted merge request !1524 "[cmake] Less verbose feature summary" at Core Modules / dune-common
Timo Koch's avatar
  • 9bc06531 · [communication][fix] Fix data type of isend