Skip to content
Snippets Groups Projects
Commit ad51e732 authored by Dominic Kempf's avatar Dominic Kempf Committed by Andreas Dedner
Browse files

[cmake][bugfix] Also use additional pip params when building a wheel

remove --upgrade for now to test if CI work better.
Could be added only if additional pip params are not provided
parent a815ca23
No related branches found
No related tags found
1 merge request!932Merge of small MRs that make changes to the Python bindings
......@@ -85,7 +85,7 @@ function(dune_python_install_package)
endif()
set(INSTALL_CMDLINE -m pip install
"${INSTALL_OPTION}" --upgrade "${WHEEL_OPTION}" "${EDIT_OPTION}" ${PYINST_ADDITIONAL_PIP_PARAMS} ${DUNE_PYTHON_ADDITIONAL_PIP_PARAMS}
"${INSTALL_OPTION}" "${WHEEL_OPTION}" "${EDIT_OPTION}" ${PYINST_ADDITIONAL_PIP_PARAMS} ${DUNE_PYTHON_ADDITIONAL_PIP_PARAMS}
"${PYINST_FULLPATH}")
......@@ -141,7 +141,7 @@ function(dune_python_install_package)
#
# Construct the wheel installation commandline
set(WHEEL_COMMAND ${Python3_EXECUTABLE} -m pip wheel -w ${DUNE_PYTHON_WHEELHOUSE} ${PYINST_FULLPATH})
set(WHEEL_COMMAND ${Python3_EXECUTABLE} -m pip wheel -w ${DUNE_PYTHON_WHEELHOUSE} ${PYINST_FULLPATH} ${PYINST_ADDITIONAL_PIP_PARAMS} ${DUNE_PYTHON_ADDITIONAL_PIP_PARAMS})
# Add the installation rule
install(CODE "message(\"Installing wheel for python package at ${PYINST_FULLPATH}...\")
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment