Skip to content
Snippets Groups Projects
  1. Jan 09, 2014
    • Markus Blatt's avatar
      [release,bugfix] Makes PKG_CONFIG_PATH honor all (lib lib/multiarch). · 8d81ff3b
      Markus Blatt authored
      Previously some of the pathes (e.g the multiarch ones) took precedence
      over the others. But as with same some of the pkgconfig files are installed
      below lib/<multiarch> and others (if there is not object library) are not.
      With this patch all possible install locations of pkgconfig files are added
      to the path if they exist.
      8d81ff3b
  2. Jan 08, 2014
  3. Jan 07, 2014
  4. Jan 04, 2014
    • Markus Blatt's avatar
      [autotools,bugfix] Feed include path of all modules to dune-autogen · c57e6037
      Markus Blatt authored
      Previously only the include path of the local modules were used. This
      caused errors with installed dune-common modules, similar to:
      
      --> aclocal...
      
      Error: Could not find dune-common/am!
      Usage: dune-autogen DUNE_MODULE_PATH_LIST [options]
        --ac=, --acversion=VERSION   use a specific VERSION of autoconf
        --am=, --amversion=VERSION   use a specific VERSION of automake
        -h,    --help                you already found this :-)
      --- Failed to build dune-typetree ---
      Terminating dunecontrol due to previous errors!
      
      This is also related to https://dune-project.org/flyspray/index.php?do=details&task_id=891
      
      With this patch we include the aclocal, m4 or am directory of all modules
      (installed and local ones) and everything works again as exspected.
      c57e6037
  5. Dec 03, 2013
  6. Dec 02, 2013
  7. Nov 22, 2013
  8. Sep 18, 2013
  9. Sep 09, 2013
  10. Sep 02, 2013
  11. Aug 30, 2013
  12. Aug 20, 2013
  13. Jun 13, 2013
  14. Jun 11, 2013
  15. Jun 05, 2013
  16. May 17, 2013
    • Steffen Müthing's avatar
      [dunecontrol] Add some rudimentary protection against user errors during git config parsing · ed0d829d
      Steffen Müthing authored
      The contents of the files containing git settings is evaluated by the shell, which can
      be dangerous if such a file contains a line like 'option value; rm -rf /'. While that is
      unlikely, it might happen when people try to create a Git alias.
      
      It would be possible to completely protect users from this problem by parsing the line
      completely manually (without involving the shell), but on the other hand, being able to
      use shell features for determining option values seems like a good thing to have as well.
      
      This patch adds some rudimentary protection that protects against errors like the one shown
      above. More advanced users can still wreak havoc by abusing shell substitution
      ('option $(echo value; rm -rf /)' comes to mind), but that's not something our average user
      will do.
      
      The protection works by splitting the input line into an array first; doing so does not
      actually execute the line and so prevents anything outside of value substitutions in $()
      from being executed.
      
      Also added a comment to explain why we need to go through the extra step with the array.
      ed0d829d
  17. May 16, 2013
  18. May 15, 2013
    • Steffen Müthing's avatar
    • Steffen Müthing's avatar
      [dunecontrol] Improve path quoting in vcsetup command · 6ac1f433
      Steffen Müthing authored
      Make sure to always quote paths that are relative to PREFIX_DIR, as that variable
      may contain spaces.
      6ac1f433
    • Steffen Müthing's avatar
      [dunecontrol] Add support for Git submodules · bcde7bfa
      Steffen Müthing authored
      Some Dune users like to aggregate all the Dune modules required for a project by
      creating a Git repository with a Git submodule for every submodule. Unfortunately,
      dunecontrol currently doesn't recognize the submodule repositories currently because
      Git aggregates all repositories in the .git directory of the superproject (more
      preciselyin in the subdirectory .git/modules/). In the submodule, .git is a regular
      file that contains a referral to the actual repository directory.
      
      This patch fixes the problem by
      
      - Detecting Git directories by looking for both directories and regular files called
        .git in the module directory.
      
      - Following the referral in submodules for the hook setup to make sure the hook gets
        installed in the correct location.
      
      Fixes FS#1303.
      bcde7bfa
    • Steffen Müthing's avatar
      [dunecontrol] Fix parsing of Git configuration settings file · 4d1af34f
      Steffen Müthing authored
      dunecontrol fails to properly process Git settings where the value contains
      spaces. It was supposed to handle quoting the same way the shell does, but
      instead arguments were split at each space and quotes kept verbatim in the
      split arguments.
      
      The reason is the order in which the shell performs variable substitution and
      tokenizing, preventing the line with the Git configuration entry from being
      tokenized by the shell.
      
      This patch fixes the problem by first parsing the line into an array, which is
      then in turn expanded again with correct per-element quoting.
      
      In addition, make COMMENT helper variables local while we're at it.
      4d1af34f
  19. May 13, 2013
    • Christian Engwer's avatar
      [dunecontrol] · 8b16eb31
      Christian Engwer authored
      quick-fix to make CMAKE builds respect the DUNE_BUILDDIR entry in opts
      files
      8b16eb31
Loading