dunecontrol handling of cmake/configure options partially broken
While working on the CMakePresets.json
generator #372 I observed that there are a couple of inconsistencies in the handling of parameters for cmake/configure.
configure
is intended as an alisa for cmake
, but when reading configurations from the $DUNE_OPTS_FILE
the behaviour is to some extent inconsistent.
- it used different flags when running
dunecontrol configure
(CMAKE_FLAGS
andCONFIGURE_FLAGS
) anddunecontrol cmake
(onlyCMAKE_FLAGS
)$\rightarrow$
made consistent - the
CMAKE_MODULE_PATH
was added to the cmake flags, but not read from the opts file$\rightarrow$
read from opts file if present - additionally
-DDUNE_OPTS_FILE=\"$DUNE_OPTS_FILE\"
was added to the cmake flags, but only when callingdunecontrol configure
$\rightarrow$
works now withconfigure
andcmake
We either need to cleanup this opts-file handling or simply remove/deprecate the command configure
.
Edited by Christian Engwer