[math] Use integer type in Factorial

Using an enum has the side effect that you can't do arithmetic without explicitly casting to an integer type. This also produced a compiler warning with clang 10 "arithmetic between different enumeration types is deprecated" -Wdeprecated-anon-enum-enum-conversion

Looks okay to me. Eventually we would probably want factorial to be an actual method, which can then return auto.

Is this change worth documenting in the changelog?

added 1 commit

• 50e5f071 - [math] Deprecated struct Factorial (use factorial function)

Compare with previous version

changed title from [math] Use int in Factorial to [math] Use integer type in Factorial

Sorry, I have broken the pipeline. Should be fixed now. Just run the pipeline again.

added 1 commit

• c56458e2 - [math] Use integer type in Factorial and deprecate struct version (use factorial function)

Compare with previous version

added 1 commit

• bb0ea7d5 - [math] Use integer type in Factorial and deprecate struct version (use factorial function)

Compare with previous version

added 1 commit

• 5b8c9776 - [math] Use integer type in Factorial and deprecate struct version (use factorial function)

Compare with previous version

added 1 commit

• ee9db7a5 - [math] Use integer type in Factorial and deprecate struct version (use factorial function)

Compare with previous version

added 1 commit

• d57c6a98 - [test][math] Improve factorial/binomial test and use function factorial...

Compare with previous version

resolved all threads

Pipeline passed for the first commit. So I also added another one adjusting the unit test for factorial/binomial to use the function version.

Looks ok to me. When you are ready, just set Oliver or me as "Assignee". Then we can merge it.

assigned to @simon.praetorius

mentioned in commit eefc417c

merged