Skip to content
Snippets Groups Projects

[Python] avoid logging both 'generating' and 'compiling' module in two lines

Merged [Python] avoid logging both 'generating' and 'compiling' module in two lines
feature/avoidGenerationAndCompilingInfo into master
1 unresolved thread
Merged Andreas Dedner requested to merge feature/avoidGenerationAndCompilingInfo into master
1 unresolved thread

Merge request reports

Pipeline #41454 passed

Stage: test
Stage: downstream
Pipeline: Dune Nightly Test

#41456

    Pipeline passed for 1951c018 on feature/avoidGenerationAndCompilingInfo

    Approval is optional

    Merged by Andreas DednerAndreas Dedner 3 years ago (Nov 18, 2021 7:28pm UTC)

    Loading

    Pipeline #41458 passed

    Stage: test
    Stage: downstream
    Pipeline: Dune Nightly Test

    #41459

      Pipeline passed for a85c317c on master

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      python/dune/generator/cmakebuilder.py
      265 278 found = line in out.read()
      266 279 if not os.path.isfile(sourceFileName) or not found:
      267 280 logger.info("Generating " + pythonName)
      281 # don't print 'Compiling' twice
      • Timo Koch
        Timo Koch @tkoch ·
        Owner

        this wouldn't print Compiling twice, no? It would print Generating and then Compiling which are two separate steps? So at least the comment is wrong.

        Edited by Timo Koch
      • Timo Koch
        Timo Koch @tkoch ·
        Owner

        seems more logical to me to have a separate log level for this (if this is too much output) instead of this hacky overwrite kind of thing

      • Andreas Dedner
        Andreas Dedner @andreas.dedner ·
        Author Owner

        generating/updating always leads to compilation so no reason to print it twice or have a different log level in my opinion. If you think this information is important then change the generating message to generating and compiling. As a developer I just want to know if a module is being newly generated, or the generated code has been updated, or if it's being recompiled. As a user I want to know why nothing sees to be happening.

      • Timo Koch
        Timo Koch @tkoch ·
        Owner

        I just wanted to say the code comment is wrong

      • Andreas Dedner
        Andreas Dedner @andreas.dedner ·
        Author Owner

        Then please just change it!

      • Please register or sign in to reply
      Please register or sign in to reply