Skip to content
Snippets Groups Projects

Fix/python bindings python requirements

Merged Timo Koch requested to merge fix/python-bindings-python-requirements into master
  • Add the requirement Python >= 3.6 for the Python bindings (#275). If the version is less, a hopefully informative message, friendly, but still attention-grabbing message is printed.
  • Remove the check for the Python interpreter which was unreachable anyway due to a check further up
  • Fixes #297 (closed)
  • Unconditionally define add_python_targets for ease of use

This MR only concerns the Python bindings not Python support for possible other usages. This is why I didn't require the Python version via the find_package mechanism for now.

Edited by Timo Koch

Merge request reports

Pipeline #60518 passed

Pipeline: Dune Nightly Test

#60520

    Pipeline passed for a3f11ed2 on fix/python-bindings-python-requirements

    Merged by Timo KochTimo Koch 2 years ago (Feb 22, 2023 12:03pm UTC)

    Loading

    Pipeline #60530 passed

    Pipeline: Dune Nightly Test

    #60531

      Pipeline passed for b4e28a19 on master

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Timo Koch mentioned in merge request !1102 (closed)

      mentioned in merge request !1102 (closed)

    • Timo Koch added 9 commits

      added 9 commits

      • 7ecc1fbb...5d96cbcc - 4 commits from branch master
      • 67cb9c77 - [python][cmake] Require Python version 3.6 for the bindings (only) and improve user messages
      • 9e911c03 - [python][cmake] Remove unreachable check for Python interpreter
      • 54a1be67 - [python][cmake] Add status message that the Python bindings have been enabled
      • 8ba63fad - Set DUNE_ENABLE_PYTHONBINDINGS to OFF if there is no python.
      • a9b3675e - [cmake][python] Harmonize messages

      Compare with previous version

    • Timo Koch added 1 commit

      added 1 commit

      • 260255a7 - [cmake][python] Harmonize messages

      Compare with previous version

    • Timo Koch added 1 commit

      added 1 commit

      • a2d2b353 - [cmake][python] Harmonize messages

      Compare with previous version

    • Timo Koch added 1 commit

      added 1 commit

      • 73169abb - Unconditionally define add_python_targets for ease of use.

      Compare with previous version

    • Timo Koch added 2 commits

      added 2 commits

      • 44451b0c - [cmake][python] Properly introduce and overwrite the global option DUNE_ENABLE_PYTHONBINDINGS
      • fa46869e - [cmake] Add todo comment for add_python_targets rename

      Compare with previous version

    • Timo Koch changed the description

      changed the description

    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Please register or sign in to reply
      Loading