Fix/python bindings python requirements
- Add the requirement Python >= 3.6 for the Python bindings (#275). If the version is less, a hopefully informative message, friendly, but still attention-grabbing message is printed.
- Remove the check for the Python interpreter which was unreachable anyway due to a check further up
- Fixes #297 (closed)
- Unconditionally define add_python_targets for ease of use
This MR only concerns the Python bindings not Python support for possible other usages. This is why I didn't require the Python version via the find_package
mechanism for now.
Edited by Timo Koch
Merge request reports
Activity
added buildsystem python labels
assigned to @andreas.dedner
requested review from @simon.praetorius
added 1 commit
- fe4d12c6 - [python][cmake] Add status message that the Python bindings have been enabled
added 1 commit
- 7ecc1fbb - [changelog] Mention required Python version for bindings
- Resolved by Timo Koch
- Resolved by Timo Koch
mentioned in merge request !1102 (closed)
added 9 commits
-
7ecc1fbb...5d96cbcc - 4 commits from branch
master
- 67cb9c77 - [python][cmake] Require Python version 3.6 for the bindings (only) and improve user messages
- 9e911c03 - [python][cmake] Remove unreachable check for Python interpreter
- 54a1be67 - [python][cmake] Add status message that the Python bindings have been enabled
- 8ba63fad - Set DUNE_ENABLE_PYTHONBINDINGS to OFF if there is no python.
- a9b3675e - [cmake][python] Harmonize messages
Toggle commit list-
7ecc1fbb...5d96cbcc - 4 commits from branch
added 1 commit
- 73169abb - Unconditionally define add_python_targets for ease of use.
Please register or sign in to reply