Disable warnings in clang properly

Summary

Disable warning -Wbitwise-instead-of-logical only for clang where the warning actually exists (i.e. >= 14) and call #pragma diagnostic pop only if previously called push.

assigned to @simon.praetorius

added 1 commit

• 72b9b470 - Disable warnings in clang properly

Compare with previous version

changed the description

Doesn't seem to work. From the runner with Clang 10:

501/builds/core/dune-common/dune/common/test/arithmetictestsuite.hh:602:34: warning: bitwise negation of a boolean expression; did you mean logical negation? [-Wbool-operation]
          DUNE_TEST_CHECK(bool(T(~T(T(i) ^ T(j))) == T(~(i^j))));
                                 ^~~~~~~~~~~~~~~

added 1 commit

• 8dcff4a8 - Disable -Wbool-operation as well

Compare with previous version

added 1 commit

• 2e3e97bb - Disable bitwise operation warning in more files

Compare with previous version

resolved all threads

merged

mentioned in commit 5dcb1e2b