Skip to content
Snippets Groups Projects

Add option to install concrete python requirements

All threads resolved!

Depending on the situation, fulfilling the concrete package requirements (from requirements.txt) is required. Usually, abstract dependencies (from setup.py) are sufficient. This MR simply makes concrete dependency installation optional.

Additionally, this MR fixes a little bug in CMake when installing abstract dependencies.

Edited by Santiago Ospina De Los Ríos

Merge request reports

Pipeline #53778 passed

Pipeline: Dune Nightly Test

#53780

    Pipeline passed for 2d84eba7 on feature/optionally-install-concrete-python-requirements

    Merged by Andreas DednerAndreas Dedner 2 years ago (Sep 22, 2022 7:18pm UTC)

    Loading

    Pipeline #53872 passed

    Pipeline: Dune Nightly Test

    #53873

      Pipeline passed for 0a430ebe on master

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • resolved all threads

    • added 1 commit

      • 84cb7955 - Apply 1 suggestion(s) to 1 file(s)

      Compare with previous version

    • added 1 commit

      • 640a2ada - Add option to optionally install concrete python requirements

      Compare with previous version

    • Santiago Ospina De Los Ríos marked this merge request as ready

      marked this merge request as ready

    • resolved all threads

    • added 20 commits

      Compare with previous version

    • added 7 commits

      Compare with previous version

    • I'm happy for this to be merged - this issue with the failing mpi seems not directly reproducible and unlikely to be caused by this MR in any case.

    • As I said: before the modularization of the install function there was no option for requirement files. The new if involves PYCONFDEPS_INSTALL_CONCRETE_DEPENDENCIE which is new. So the change in behavior is quite local in time (and not between different releases anyway).

      If I get no objections I'll merge this end of the week.

    • Looks good for me.

    • Andreas Dedner resolved all threads

      resolved all threads

    • Andreas Dedner approved this merge request

      approved this merge request

    • Andreas Dedner mentioned in commit 0a430ebe

      mentioned in commit 0a430ebe

    • Andreas Dedner picked the changes into the branch cherry-pick-0a430ebe with commit a5fdca69

      picked the changes into the branch cherry-pick-0a430ebe with commit a5fdca69

    • Andreas Dedner mentioned in commit a5fdca69

      mentioned in commit a5fdca69

    • Andreas Dedner mentioned in merge request !1172 (merged)

      mentioned in merge request !1172 (merged)

    • Please register or sign in to reply
      Loading