Add option to install concrete python requirements
Depending on the situation, fulfilling the concrete package requirements (from requirements.txt
) is required. Usually, abstract dependencies (from setup.py
) are sufficient. This MR simply makes concrete dependency installation optional.
Additionally, this MR fixes a little bug in CMake when installing abstract dependencies.
Merge request reports
Activity
changed milestone to %DUNE 2.9.0
added buildsystem label
requested review from @andreas.dedner
assigned to @santiago.ospina
- Resolved by Santiago Ospina De Los Ríos
This is normal, right? Ubuntu 18 is not able to fetch the python packages.
- Resolved by Santiago Ospina De Los Ríos
- Resolved by Santiago Ospina De Los Ríos
Running github testing action https://github.com/dune-project/dune-testpypi/actions/runs/2727007758
added 1 commit
- 640a2ada - Add option to optionally install concrete python requirements
mentioned in issue #280 (closed)
added 20 commits
-
640a2ada...14766f4f - 19 commits from branch
master
- dc80c03e - Add option to optionally install concrete python requirements
-
640a2ada...14766f4f - 19 commits from branch
- Resolved by Andreas Dedner
Please test this with the downstream pipelines in https://gitlab.dune-project.org/infrastructure/dune-nightly-test/-/pipelines.
added 7 commits
-
dc80c03e...d53c04f5 - 6 commits from branch
master
- 2d84eba7 - Add option to optionally install concrete python requirements
-
dc80c03e...d53c04f5 - 6 commits from branch
- Resolved by Santiago Ospina De Los Ríos
As I said: before the modularization of the install function there was no option for requirement files. The new if involves
PYCONFDEPS_INSTALL_CONCRETE_DEPENDENCIE
which is new. So the change in behavior is quite local in time (and not between different releases anyway).If I get no objections I'll merge this end of the week.
mentioned in commit 0a430ebe
picked the changes into the branch
cherry-pick-0a430ebe
with commit a5fdca69mentioned in commit a5fdca69
mentioned in merge request !1172 (merged)