Skip to content
Snippets Groups Projects

upgrade to pybind11 2.10.1

Merged Andreas Dedner requested to merge feature/upgradePybind11 into master
1 unresolved thread

Might require remove dune-py before use but not sure

Edited by Andreas Dedner

Merge request reports

Pipeline #55130 passed

Pipeline: Dune Nightly Test

#55132

    Pipeline passed for 38ac7a52 on feature/upgradePybind11

    Approval is optional

    Merged by Andreas DednerAndreas Dedner 2 years ago (Nov 8, 2022 6:16pm UTC)

    Merge details

    • Changes merged into master with 2bc426e9.
    • Deleted the source branch.

    Pipeline #55194 passed

    Pipeline: Dune Nightly Test

    #55197

      Pipeline passed for 2bc426e9 on master

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      • @robert.kloefkorn @samuel.burbulla @christi @tkoch if you have time would be great if you could test this

      • Andreas Dedner changed the description

        changed the description

      • Andreas Dedner added 1 commit

        added 1 commit

        • 38ac7a52 - upgrade python version adding 3.11 and 3.12 to list

        Compare with previous version

      • I don't observe any issues, thanks for upgrading!

        • There is an issue in my GitHub CI with the Mac runner. No issues locally.

          --- calling make for dune-common ---
          build directory: build-cmake
          cmake --build . -- 
          [ 20%] Building CXX object python/dune/typeregistry/CMakeFiles/_typeregistry.dir/_typeregistry.cc.o
          [ 20%] Building CXX object CMakeFiles/dunecommon.dir/dune/common/debugalign.cc.o
          [ 20%] Building CXX object CMakeFiles/dunecommon.dir/dune/common/debugallocator.cc.o
          In file included from /Users/runner/work/dune-mmesh/dune-common/python/dune/typeregistry/_typeregistry.cc:8:
          In file included from /Users/runner/work/dune-mmesh/dune-common/dune/python/common/typeregistry.hh:21:
          In file included from /Users/runner/work/dune-mmesh/dune-common/dune/python/pybind11/pybind11.h:45:
          In file included from /Users/runner/work/dune-mmesh/dune-common/dune/python/pybind11/attr.h:13:
          /Users/runner/work/dune-mmesh/dune-common/dune/python/pybind11/cast.h:446:36: error: member access into incomplete type 'PyFrameObject' (aka '_frame')
                          "  " + handle(frame->f_code->co_filename).cast<std::string>() +
                                             ^
          /Library/Frameworks/Python.framework/Versions/3.11/include/python3.11/pytypedefs.h:22:16: note: forward declaration of '_frame'
          typedef struct _frame PyFrameObject;
                         ^
          In file included from /Users/runner/work/dune-mmesh/dune-common/python/dune/typeregistry/_typeregistry.cc:8:
          In file included from /Users/runner/work/dune-mmesh/dune-common/dune/python/common/typeregistry.hh:21:
          In file included from /Users/runner/work/dune-mmesh/dune-common/dune/python/pybind11/pybind11.h:45:
          In file included from /Users/runner/work/dune-mmesh/dune-common/dune/python/pybind11/attr.h:13:
          /Users/runner/work/dune-mmesh/dune-common/dune/python/pybind11/cast.h:448:29: error: member access into incomplete type 'PyFrameObject' (aka '_frame')
                          handle(frame->f_code->co_name).cast<std::string>() + "\n";
                                      ^
          /Library/Frameworks/Python.framework/Versions/3.11/include/python3.11/pytypedefs.h:22:16: note: forward declaration of '_frame'
          typedef struct _frame PyFrameObject;
          ...

          Edit: Sorry, which was not running with this branch.

          Edited by Samuel Burbulla
        • The issue is fixed with this upgrade of pybind11. This emphasises the relevance of this upgrade.

        • Please register or sign in to reply
      • Andreas Dedner mentioned in commit 2bc426e9

        mentioned in commit 2bc426e9

      • Andreas Dedner picked the changes into the branch cherry-pick-2bc426e9 with commit b2bd2868

        picked the changes into the branch cherry-pick-2bc426e9 with commit b2bd2868

      • Andreas Dedner mentioned in commit b2bd2868

        mentioned in commit b2bd2868

      • Andreas Dedner mentioned in merge request !1253 (merged)

        mentioned in merge request !1253 (merged)

      Please register or sign in to reply
      Loading