[python][test] Use python3 in dune_python_add_test

This was hard-coded to python before but a better default might be python3 since we require Python 3 (According to https://peps.python.org/pep-0394/, python doesn't even have to exist and if it exists may point to either Python 2 or 3).

This also fixes a problem that came up in !1222 (merged) when trying to use the Dune bindings without a virtual env on a system where python points to python2.

added bugfix python labels

mentioned in merge request !1222 (merged)

approved this merge request

mm this of course fails also for my own second setup described in !1222 (merged) with a separate venv because the python interpreter is then set at configure time. Actually, we probably want there the interpreter of the current environment. I guess this is why is what hard coded to python. But isn't python3 a better choice?

marked this merge request as draft

resolved all threads

added 1 commit

• 98b27f6c - fixup

Compare with previous version

changed title from Draft: [fix][python][test] Use Python3_EXECUTABLE in dune_python_add_test to Draft: [fix][python][test] Use python3 in dune_python_add_test

changed the description

@samuel.burbulla Do you see any problems with this? I'm asking because you previously worked on the dune_python_add_test a lot.

removed bugfix label

marked this merge request as ready

changed title from Draft: [fix][python][test] Use python3 in dune_python_add_test to [python][test] Use python3 in dune_python_add_test

This is ok from my side. Should be merged.

assigned to @andreas.dedner

requested review from @samuel.burbulla

added 1 commit

• 63e9efa0 - [python][test] Use python3 instead of python in dune_python_add_test

Compare with previous version

changed the description

approved this merge request

resolved all threads

approved this merge request

I'm ok with this being merged. However, it is a corner case because you want to run the python tests with a python environment that is configured later but the dune python modules are build with the system python version. This could lead to linkage errors. Nevertheless, I'm fine with this change.

changed the description

resolved all threads

assigned to @tkoch and unassigned @andreas.dedner

https://github.com/dune-project/dune-testpypi/actions/runs/4235947738

@tkoch: I guess it's fine, but I was wanting to wait with the testing until after !1222 (merged) was merged.

merged

mentioned in commit 792d611e